Always use do/end for multiline lambdas #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously lambda blocks inside a Command/CommandCall were always using braces, even when multiline.
|
For the life of me I can't figure out why that is there. I think it was in there when the lambda was an argument? As in foo -> { bar } do endbut that appears to be fine. Maybe it wasn't in 2.6 when I made this? Not sure. Either way, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379
Previously lambda blocks inside a Command/CommandCall were always using braces, even when multiline.
This removes the special handling of multiline lambda blocks, that was forcing curly braces when any of the parents were a
CommandorCommandCall.I don't understand why that was there so I can't tell if it's somehow important, but no tests failed and it made the two added fixtures pass.