Skip to content

Create a rake task for checking and formatting with Syntax Tree #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kddnewton opened this issue May 7, 2022 · 3 comments · Fixed by #74
Closed

Create a rake task for checking and formatting with Syntax Tree #70

kddnewton opened this issue May 7, 2022 · 3 comments · Fixed by #74
Assignees
@wenderjean
Labels
good first issue Good for newcomers

Comments

@kddnewton
Copy link
Member

For inspiration, check out: https://github.com/prettier/plugin-ruby/blob/main/lib/prettier/rake/task.rb.
@kddnewton kddnewton added the good first issue Good for newcomers label May 7, 2022
@wenderjean
Copy link
Contributor

@kddnewton Would you mind assign this one to me? I'd like to give it a try and have my feet wet in syntax_tree :)

@kddnewton
Copy link
Member Author

Done! Let me know if you get stuck.

@wenderjean wenderjean mentioned this issue May 10, 2022
Merged
@wenderjean
Copy link
Contributor

@kddnewton I created a draft PR to validate the approach I decided to use, when you have some time let me know if I'm in the right way. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenderjean wenderjean

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Rake test to run check and format commands wenderjean/syntax_tree
2 participants
@wenderjean @kddnewton