Skip to content

Bundle the extension with esbuild #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kddnewton opened this issue Jul 20, 2022 · 3 comments
Closed

Bundle the extension with esbuild #35

kddnewton opened this issue Jul 20, 2022 · 3 comments

Comments

@kddnewton
Copy link
Member

https://code.visualstudio.com/api/working-with-extensions/bundling-extension

@kddnewton
Copy link
Member Author

@xeger wanna take a shot at this? The docs look pretty clear on this, shouldn't be too bad. Seems like something worth doing (I get a warning every time I publish it that I should be doing this).

@xeger
Copy link
Contributor

xeger commented Jul 20, 2022

It wasn't a slam dunk, but I made a start at it for you. See the PR for my concerns.

I'm mildly surprised that the official Microsoft documentation has people bundling tests with tsc, and distributables with esbuild -- they must really trust both tools!

@xeger
Copy link
Contributor

xeger commented Jul 22, 2022

The PR is ready to go @kddnewton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants