-
-
Notifications
You must be signed in to change notification settings - Fork 7
Launches atlassian Sourcetree.app (naming collision) #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
P.S. Just left the very first review in the VSCode marketplace ;) |
Interesting @counterbeing! I had no idea that We do supply the ability to specify the path, but I agree that that's not a great default experience. I'm thinking we could probably inspect the PATH environment variable ourselves and do something smart. For example, we could find all of the path entries that contain "ruby" in the name. Try something for me. If you run the following program, does path =
ENV["PATH"].split(":").detect do |directory|
executable = File.join(directory, "stree")
break executable if directory.include?("ruby") && File.exists?(executable)
end |
@counterbeing I opened up a PR I think will fix this, but want to verify this first, so let me know if you get a chance to run that. |
That does appear to return a path!
I suppose the other thing worth noting is that I'm running my ruby under |
This should be out in v0.5.0! |
On my system, there is a binary present called
stree
which is for opening the sourcetree app. I know this app has been around for quite some time, and this isn't an invention of mine. I'm just imagining that there might be a lot of people with anstree
binary already on their system.Upon installing the app, it opened up the sourcetree app in five different directories on my system. I'm wondering if there's some way to detect the appropriate binary by default?
I've gotten it working by manually configuring the path to the gem, and it seems to be great! I just don't want this naming collision to possibly hamper adoption.
Thanks so much!
Cory
The text was updated successfully, but these errors were encountered: