use the typescript version that is adjacent to the `tsconfig.json`

[despairblue]

Thanks for working on this.

I'm using javascript-typescript-langserver in atom via ide-typescript. At the moment javascript-typescript-langserver is using it's bundled typescript version. But that leads to projects using features from newer typescript versions to be broken. It could also lead to projects using older typescript version not working because some default behaviour changed.

At the moment I get around this issue by cd-ing into the installed javascript-typescript-langserver's directory and upgrading the typescript dependency manually npm i typescript@latest.

I made a repro repo. It's using string enum that have been added in ts 2.4 thus it's not working. Running npm run build builds it fine using the installed typescript@2.5.

[felixfbecker]

Hmm, updating the TS version here usually resulted in breaking API changes that need to be resolved: #312
So I wonder to what extend we can make this even configurable. Might have to do feature detection. But agree, this is needed, feel free to do a PR

[despairblue]

That's because this package uses TS internals right? Starting a tsserver and proxying (well and translating) the calls is no option? I could try to make a PR upgrading to TS 2.5, until I have had time to think about how to handle the feature detection stuff...I may have an idea but it's hacky at best, not sure if there is a clean way to do this.

On Wed, Sep 13, 2017, 18:13 Felix Becker ***@***.***> wrote: Hmm, updating the TS version here usually resulted in breaking API changes that need to be resolved: #312 <#312> So I wonder to what extend we can make this even configurable. Might have to do feature detection. But agree, this is needed, feel free to do a PR — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4neTSS8OIWdyYjzQn1j7JNYG5l713gks5sh_8tgaJpZM4PWDhP> .

-- Q: Why is this email five sentences or less? A: http://five.sentenc.es

[felixfbecker]

Depends on what you mean with "internals". Just like tsserver itself, this package exposes the Language Service API through an RPC protocol.

https://github.com/Microsoft/TypeScript/wiki/Architectural-Overview

[tomv564]

It's not such much the "internals" as the hard dependency on a typescript version.
The language service could declare typescript as a peer dependency to give you some version flexibility when installing.

The proxy setup you described is already explored here: https://github.com/prabirshrestha/typescript-language-server

Upgrading to 2.5 will probably be the easiest fix.

[bilby91]

Any updates on this ? Interested in this for the ide-typescriptfeature!

[felixfbecker]

@bilby91 you're invited to pick up #359 :)

[bilby91]

Hey, Sure! It's just bumping version and seeing how it affects? I'll try to play with it this night! Thanks! Martín

…

On Wed, Oct 11, 2017 at 18:11 Felix Becker < Felix Becker ( Felix Becker ***@***.***> ) > wrote: @bilby91 ( https://github.com/bilby91 ) you're invited to pick up #359 ( #359 ) :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( #350 (comment) ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/ACGV91MYswMG2ojpjdwoFxtZJjsfZqBDks5srS7kgaJpZM4PWDhP ).

[felixfbecker]

The version is already bumped, but as you can see a lot of tests are failing.