Unify method visibility of private classes

Apply checkstyle rule to ensure that private and package private
classes do not have unnecessary public methods. Test classes have
also been unified as much as possible to use default scoped
inner-classes.

Closes gh-7316

Author: philwebb

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/cloudfoundry/reactive/ReactiveCloudFoundryActuatorAutoConfiguration.java

@@ -155,7 +155,7 @@ private CorsConfiguration getCorsConfiguration() {
 	static class IgnoredPathsSecurityConfiguration {
 
 		@Bean
-		public WebFilterChainPostProcessor webFilterChainPostProcessor() {
+		WebFilterChainPostProcessor webFilterChainPostProcessor() {
 			return new WebFilterChainPostProcessor();
 		}
 

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/cloudfoundry/reactive/ReactiveCloudFoundrySecurityService.java

@@ -83,8 +83,7 @@ private SslContextBuilder createSslContext() {
 	 * @return a Mono of the access level that should be granted
 	 * @throws CloudFoundryAuthorizationException if the token is not authorized
 	 */
-	public Mono<AccessLevel> getAccessLevel(String token, String applicationId)
-			throws CloudFoundryAuthorizationException {
+	Mono<AccessLevel> getAccessLevel(String token, String applicationId) throws CloudFoundryAuthorizationException {
 		String uri = getPermissionsUri(applicationId);
 		return this.webClient.get().uri(uri).header("Authorization", "bearer " + token).retrieve().bodyToMono(Map.class)
 				.map(this::getAccessLevel).onErrorMap(this::mapError);
@@ -118,7 +117,7 @@ private String getPermissionsUri(String applicationId) {
 	 * Return a Mono of all token keys known by the UAA.
 	 * @return a Mono of token keys
 	 */
-	public Mono<Map<String, String>> fetchTokenKeys() {
+	Mono<Map<String, String>> fetchTokenKeys() {
 		return getUaaUrl().flatMap(this::fetchTokenKeys);
 	}
 
@@ -141,7 +140,7 @@ private Map<String, String> extractTokenKeys(Map<String, Object> response) {
 	 * Return a Mono of URL of the UAA.
 	 * @return the UAA url Mono
 	 */
-	public Mono<String> getUaaUrl() {
+	Mono<String> getUaaUrl() {
 		this.uaaUrl = this.webClient.get().uri(this.cloudControllerUrl + "/info").retrieve().bodyToMono(Map.class)
 				.map((response) -> (String) response.get("token_endpoint")).cache()
 				.onErrorMap((ex) -> new CloudFoundryAuthorizationException(Reason.SERVICE_UNAVAILABLE,

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/cloudfoundry/reactive/ReactiveTokenValidator.java

@@ -50,7 +50,7 @@ class ReactiveTokenValidator {
 		this.securityService = securityService;
 	}
 
-	public Mono<Void> validate(Token token) {
+	Mono<Void> validate(Token token) {
 		return validateAlgorithm(token).then(validateKeyIdAndSignature(token)).then(validateExpiry(token))
 				.then(validateIssuer(token)).then(validateAudience(token));
 	}

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/cloudfoundry/servlet/CloudFoundrySecurityService.java

@@ -65,7 +65,7 @@ class CloudFoundrySecurityService {
 	 * @return the access level that should be granted
 	 * @throws CloudFoundryAuthorizationException if the token is not authorized
 	 */
-	public AccessLevel getAccessLevel(String token, String applicationId) throws CloudFoundryAuthorizationException {
+	AccessLevel getAccessLevel(String token, String applicationId) throws CloudFoundryAuthorizationException {
 		try {
 			URI uri = getPermissionsUri(applicationId);
 			RequestEntity<?> request = RequestEntity.get(uri).header("Authorization", "bearer " + token).build();
@@ -99,7 +99,7 @@ private URI getPermissionsUri(String applicationId) {
 	 * Return all token keys known by the UAA.
 	 * @return a list of token keys
 	 */
-	public Map<String, String> fetchTokenKeys() {
+	Map<String, String> fetchTokenKeys() {
 		try {
 			return extractTokenKeys(this.restTemplate.getForObject(getUaaUrl() + "/token_keys", Map.class));
 		}
@@ -121,7 +121,7 @@ private Map<String, String> extractTokenKeys(Map<?, ?> response) {
 	 * Return the URL of the UAA.
 	 * @return the UAA url
 	 */
-	public String getUaaUrl() {
+	String getUaaUrl() {
 		if (this.uaaUrl == null) {
 			try {
 				Map<?, ?> response = this.restTemplate.getForObject(this.cloudControllerUrl + "/info", Map.class);

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/cloudfoundry/servlet/TokenValidator.java

@@ -46,7 +46,7 @@ class TokenValidator {
 		this.securityService = cloudFoundrySecurityService;
 	}
 
-	public void validate(Token token) {
+	void validate(Token token) {
 		validateAlgorithm(token);
 		validateKeyIdAndSignature(token);
 		validateExpiry(token);

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/endpoint/web/WebEndpointAutoConfiguration.java

@@ -136,7 +136,7 @@ static class WebEndpointServletConfiguration {
 
 		@Bean
 		@ConditionalOnMissingBean(ServletEndpointsSupplier.class)
-		public ServletEndpointDiscoverer servletEndpointDiscoverer(ApplicationContext applicationContext,
+		ServletEndpointDiscoverer servletEndpointDiscoverer(ApplicationContext applicationContext,
 				ObjectProvider<PathMapper> endpointPathMappers,
 				ObjectProvider<EndpointFilter<ExposableServletEndpoint>> filters) {
 			return new ServletEndpointDiscoverer(applicationContext,

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/endpoint/web/jersey/JerseyWebEndpointManagementContextConfiguration.java

@@ -60,7 +60,7 @@
 class JerseyWebEndpointManagementContextConfiguration {
 
 	@Bean
-	public ResourceConfigCustomizer webEndpointRegistrar(WebEndpointsSupplier webEndpointsSupplier,
+	ResourceConfigCustomizer webEndpointRegistrar(WebEndpointsSupplier webEndpointsSupplier,
 			ServletEndpointsSupplier servletEndpointsSupplier, EndpointMediaTypes endpointMediaTypes,
 			WebEndpointProperties webEndpointProperties) {
 		List<ExposableEndpoint<?>> allEndpoints = new ArrayList<>();

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/health/HealthEndpointConfiguration.java

@@ -38,7 +38,7 @@ class HealthEndpointConfiguration {
 
 	@Bean
 	@ConditionalOnMissingBean
-	public HealthEndpoint healthEndpoint(HealthAggregator healthAggregator, HealthIndicatorRegistry registry) {
+	HealthEndpoint healthEndpoint(HealthAggregator healthAggregator, HealthIndicatorRegistry registry) {
 		return new HealthEndpoint(new CompositeHealthIndicator(healthAggregator, registry));
 	}
 

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/health/HealthEndpointWebExtensionConfiguration.java

@@ -48,7 +48,7 @@ class HealthEndpointWebExtensionConfiguration {
 
 	@Bean
 	@ConditionalOnMissingBean
-	public HealthStatusHttpMapper createHealthStatusHttpMapper(HealthIndicatorProperties healthIndicatorProperties) {
+	HealthStatusHttpMapper createHealthStatusHttpMapper(HealthIndicatorProperties healthIndicatorProperties) {
 		HealthStatusHttpMapper statusHttpMapper = new HealthStatusHttpMapper();
 		if (healthIndicatorProperties.getHttpMapping() != null) {
 			statusHttpMapper.addStatusMapping(healthIndicatorProperties.getHttpMapping());
@@ -58,7 +58,7 @@ public HealthStatusHttpMapper createHealthStatusHttpMapper(HealthIndicatorProper
 
 	@Bean
 	@ConditionalOnMissingBean
-	public HealthWebEndpointResponseMapper healthWebEndpointResponseMapper(HealthStatusHttpMapper statusHttpMapper,
+	HealthWebEndpointResponseMapper healthWebEndpointResponseMapper(HealthStatusHttpMapper statusHttpMapper,
 			HealthEndpointProperties properties) {
 		return new HealthWebEndpointResponseMapper(statusHttpMapper, properties.getShowDetails(),
 				properties.getRoles());
@@ -72,7 +72,7 @@ static class ReactiveWebHealthConfiguration {
 		@Bean
 		@ConditionalOnMissingBean
 		@ConditionalOnBean(HealthEndpoint.class)
-		public ReactiveHealthEndpointWebExtension reactiveHealthEndpointWebExtension(
+		ReactiveHealthEndpointWebExtension reactiveHealthEndpointWebExtension(
 				ObjectProvider<HealthAggregator> healthAggregator, ReactiveHealthIndicatorRegistry registry,
 				HealthWebEndpointResponseMapper responseMapper) {
 			return new ReactiveHealthEndpointWebExtension(new CompositeReactiveHealthIndicator(
@@ -88,7 +88,7 @@ static class ServletWebHealthConfiguration {
 		@Bean
 		@ConditionalOnMissingBean
 		@ConditionalOnBean(HealthEndpoint.class)
-		public HealthEndpointWebExtension healthEndpointWebExtension(HealthEndpoint healthEndpoint,
+		HealthEndpointWebExtension healthEndpointWebExtension(HealthEndpoint healthEndpoint,
 				HealthWebEndpointResponseMapper responseMapper) {
 			return new HealthEndpointWebExtension(healthEndpoint, responseMapper);
 		}

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/health/HealthIndicatorAutoConfiguration.java

@@ -77,7 +77,7 @@ static class ReactiveHealthIndicatorConfiguration {
 
 		@Bean
 		@ConditionalOnMissingBean
-		public ReactiveHealthIndicatorRegistry reactiveHealthIndicatorRegistry(
+		ReactiveHealthIndicatorRegistry reactiveHealthIndicatorRegistry(
 				Map<String, ReactiveHealthIndicator> reactiveHealthIndicators,
 				Map<String, HealthIndicator> healthIndicators) {
 			return new ReactiveHealthIndicatorRegistryFactory()