source: webkit/trunk/JavaScriptCore/API/JSStringRefCF.cpp@ 25527

Last change on this file since 25527 was 25527, checked in by weinig, 18 years ago

Reviewed by Geoffrey Garen.

<rdar://problem/5478717> JSStringCreateWithCFString leaks when passed a zero length CFStringRef

  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Special case the zero length string and remove the UTF16 optimized path since it will always leak due to the fact that we won't be able to free the backing store that the CFStringRef provides.
File size: 2.3 KB
Line 
1// -*- mode: c++; c-basic-offset: 4 -*-
2/*
3 * Copyright (C) 2006, 2007 Apple Computer, Inc. All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution.
13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */
26
27#include "config.h"
28#include "JSStringRefCF.h"
29
30#include "APICast.h"
31#include "JSStringRef.h"
32#include <kjs/JSLock.h>
33#include <kjs/ustring.h>
34#include <kjs/value.h>
35
36using namespace KJS;
37
38JSStringRef JSStringCreateWithCFString(CFStringRef string)
39{
40 JSLock lock;
41 CFIndex length = CFStringGetLength(string);
42 UString::Rep* rep;
43 if (!length)
44 rep = UString("").rep()->ref();
45 else {
46 UniChar* buffer = static_cast<UniChar*>(fastMalloc(sizeof(UniChar) * length));
47 CFStringGetCharacters(string, CFRangeMake(0, length), buffer);
48 rep = UString(reinterpret_cast<UChar*>(buffer), length, false).rep()->ref();
49 }
50 return toRef(rep);
51}
52
53CFStringRef JSStringCopyCFString(CFAllocatorRef alloc, JSStringRef string)
54{
55 UString::Rep* rep = toJS(string);
56 return CFStringCreateWithCharacters(alloc, reinterpret_cast<const UniChar*>(rep->data()), rep->size());
57}
Note: See TracBrowser for help on using the repository browser.