source: webkit/trunk/JavaScriptCore/kjs/JSVariableObject.h@ 31226

Last change on this file since 31226 was 31226, checked in by [email protected], 17 years ago

Optimise lookup of Math, undefined, NaN and Infinity

Reviewed by Maciej

Added a method to JSVariableObject to allow us to inject DontDelete properties
into the symbol table and localStorage. This results in a 0.4% progression in
SunSpider, with a 8% gain in math-partial-sums.

  • Property svn:eol-style set to native
File size: 6.1 KB
Line 
1/*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 *
8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution.
13 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
14 * its contributors may be used to endorse or promote products derived
15 * from this software without specific prior written permission.
16 *
17 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
18 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
19 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
20 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
21 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */
28
29#ifndef JSVariableObject_h
30#define JSVariableObject_h
31
32#include "LocalStorage.h"
33#include "SymbolTable.h"
34#include "object.h"
35
36namespace KJS {
37
38 class JSVariableObject : public JSObject {
39 public:
40 SymbolTable& symbolTable() const { return *d->symbolTable; }
41 LocalStorage& localStorage() const { return d->localStorage; }
42
43 void saveLocalStorage(SavedProperties&) const;
44 void restoreLocalStorage(const SavedProperties&);
45
46 virtual void initializeVariable(ExecState*, const Identifier&, JSValue*, unsigned attributes) = 0;
47
48 virtual bool deleteProperty(ExecState*, const Identifier&);
49 virtual void getPropertyNames(ExecState*, PropertyNameArray&);
50
51 virtual void mark();
52
53 virtual bool isVariableObject() const;
54 virtual bool isDynamicScope() const = 0;
55
56 virtual bool getPropertyAttributes(const Identifier& propertyName, unsigned& attributes) const;
57
58 protected:
59 // Subclasses of JSVariableObject can subclass this struct to add data
60 // without increasing their own size (since there's a hard limit on the
61 // size of a JSCell).
62 struct JSVariableObjectData {
63 JSVariableObjectData() { }
64 JSVariableObjectData(SymbolTable* s)
65 : symbolTable(s) // Subclass owns this pointer.
66 {
67 }
68
69 LocalStorage localStorage; // Storage for variables in the symbol table.
70 SymbolTable* symbolTable; // Maps name -> index in localStorage.
71 };
72
73 JSVariableObject() { }
74
75 JSVariableObject(JSVariableObjectData* data)
76 : d(data) // Subclass owns this pointer.
77 {
78 }
79
80 JSVariableObject(JSValue* proto, JSVariableObjectData* data)
81 : JSObject(proto)
82 , d(data) // Subclass owns this pointer.
83 {
84 }
85
86 bool symbolTableGet(const Identifier&, PropertySlot&);
87 bool symbolTablePut(const Identifier&, JSValue*);
88 bool symbolTableInitializeVariable(const Identifier&, JSValue*, unsigned attributes);
89 bool symbolTableInsert(const Identifier&, JSValue*, unsigned attributes);
90
91 JSVariableObjectData* d;
92 };
93
94 inline bool JSVariableObject::symbolTableGet(const Identifier& propertyName, PropertySlot& slot)
95 {
96 size_t index = symbolTable().get(propertyName.ustring().rep());
97 if (index != missingSymbolMarker()) {
98#ifndef NDEBUG
99 // During initialization, the variable object needs to advertise that it has certain
100 // properties, even if they're not ready for access yet. This check verifies that
101 // no one tries to access such a property.
102
103 // In a release build, we optimize this check away and just return an invalid pointer.
104 // There's no harm in an invalid pointer, since no one dereferences it.
105 if (index >= d->localStorage.size()) {
106 slot.setUngettable(this);
107 return true;
108 }
109#endif
110 slot.setValueSlot(this, &d->localStorage[index].value);
111 return true;
112 }
113 return false;
114 }
115
116 inline bool JSVariableObject::symbolTablePut(const Identifier& propertyName, JSValue* value)
117 {
118 size_t index = symbolTable().get(propertyName.ustring().rep());
119 if (index == missingSymbolMarker())
120 return false;
121 LocalStorageEntry& entry = d->localStorage[index];
122 if (entry.attributes & ReadOnly)
123 return true;
124 entry.value = value;
125 return true;
126 }
127
128 inline bool JSVariableObject::symbolTableInitializeVariable(const Identifier& propertyName, JSValue* value, unsigned attributes)
129 {
130 size_t index = symbolTable().get(propertyName.ustring().rep());
131 if (index == missingSymbolMarker())
132 return false;
133 LocalStorageEntry& entry = d->localStorage[index];
134 entry.value = value;
135 entry.attributes = attributes;
136 return true;
137 }
138
139 inline bool JSVariableObject::symbolTableInsert(const Identifier& propertyName, JSValue* value, unsigned attributes)
140 {
141 if (symbolTable().get(propertyName.ustring().rep()) != missingSymbolMarker())
142 return false;
143
144 ASSERT((attributes & DontDelete) != 0);
145 size_t localStorageIndex = d->localStorage.size();
146 d->localStorage.append(LocalStorageEntry(value, attributes));
147 symbolTable().add(propertyName.ustring().rep(), localStorageIndex);
148 return true;
149 }
150} // namespace KJS
151
152#endif // JSVariableObject_h
Note: See TracBrowser for help on using the repository browser.