source: webkit/trunk/JavaScriptCore/kjs/PropertySlot.cpp@ 35900

Last change on this file since 35900 was 35806, checked in by [email protected], 17 years ago

2007-08-16 Geoffrey Garen <[email protected]>

Reviewed by Oliver Hunt.


Sped up property access for array.length and string.length by adding a
mechanism for returning a temporary value directly instead of returning
a pointer to a function that retrieves the value.


Also removed some unused cruft from PropertySlot.


SunSpider says 0.5% - 1.2% faster.

NOTE: This optimization is not a good idea in general, because it's
actually a pessimization in the case of resolve for assignment,
and it may get in the way of other optimizations in the future.

  • Property svn:eol-style set to native
File size: 1.7 KB
Line 
1/*
2 * Copyright (C) 2005, 2008 Apple Inc. All rights reserved.
3 *
4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version.
8 *
9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details.
13 *
14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA.
18 *
19 */
20
21#include "config.h"
22#include "PropertySlot.h"
23
24#include "JSFunction.h"
25#include "JSGlobalObject.h"
26#include "JSObject.h"
27
28namespace KJS {
29
30JSValue* PropertySlot::functionGetter(ExecState* exec, const Identifier&, const PropertySlot& slot)
31{
32 // Prevent getter functions from observing execution if an exception is pending.
33 if (exec->hadException())
34 return exec->exception();
35
36 CallData callData;
37 CallType callType = slot.m_data.getterFunc->getCallData(callData);
38 if (callType == CallTypeHost)
39 return callData.native.function(exec, slot.m_data.getterFunc, slot.slotBase(), exec->emptyList());
40 ASSERT(callType == CallTypeJS);
41 // FIXME: Can this be done more efficiently using the callData?
42 return static_cast<JSFunction*>(slot.m_data.getterFunc)->call(exec, slot.slotBase(), exec->emptyList());
43}
44
45} // namespace KJS
Note: See TracBrowser for help on using the repository browser.