source: webkit/trunk/JavaScriptCore/runtime/GetterSetter.cpp@ 47304

Last change on this file since 47304 was 47022, checked in by [email protected], 16 years ago

Stack overflow crash in JavaScript garbage collector mark pass
​https://bugs.webkit.org/show_bug.cgi?id=12216

Reviewed by Gavin Barraclough and Sam Weinig

Make the GC mark phase iterative by using an explicit mark stack.
To do this marking any single object is performed in multiple stages

  • The object is appended to the MarkStack, this sets the marked bit for the object using the new markDirect() function, and then returns
  • When the MarkStack is drain()ed the object is popped off the stack and markChildren(MarkStack&) is called on the object to collect all of its children. drain() then repeats until the stack is empty.

Additionally I renamed a number of methods from 'mark' to 'markAggregate'
in order to make it more clear that marking of those object was not
going to result in an actual recursive mark.
  • Property svn:eol-style set to native
File size: 2.1 KB
Line 
1/*
2 * Copyright (C) 1999-2002 Harri Porten ([email protected])
3 * Copyright (C) 2001 Peter Kelly ([email protected])
4 * Copyright (C) 2004, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 *
6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version.
10 *
11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details.
15 *
16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA.
20 *
21 */
22
23#include "config.h"
24#include "GetterSetter.h"
25
26#include "JSObject.h"
27#include <wtf/Assertions.h>
28
29namespace JSC {
30
31void GetterSetter::markChildren(MarkStack& markStack)
32{
33 JSCell::markChildren(markStack);
34
35 if (m_getter && !m_getter->marked())
36 markStack.append(m_getter);
37 if (m_setter && !m_setter->marked())
38 markStack.append(m_setter);
39}
40
41JSValue GetterSetter::toPrimitive(ExecState*, PreferredPrimitiveType) const
42{
43 ASSERT_NOT_REACHED();
44 return jsNull();
45}
46
47bool GetterSetter::getPrimitiveNumber(ExecState*, double& number, JSValue& value)
48{
49 ASSERT_NOT_REACHED();
50 number = 0;
51 value = JSValue();
52 return true;
53}
54
55bool GetterSetter::toBoolean(ExecState*) const
56{
57 ASSERT_NOT_REACHED();
58 return false;
59}
60
61double GetterSetter::toNumber(ExecState*) const
62{
63 ASSERT_NOT_REACHED();
64 return 0.0;
65}
66
67UString GetterSetter::toString(ExecState*) const
68{
69 ASSERT_NOT_REACHED();
70 return UString::null();
71}
72
73JSObject* GetterSetter::toObject(ExecState* exec) const
74{
75 ASSERT_NOT_REACHED();
76 return jsNull().toObject(exec);
77}
78
79bool GetterSetter::isGetterSetter() const
80{
81 return true;
82}
83
84} // namespace JSC
Note: See TracBrowser for help on using the repository browser.