source: webkit/trunk/JavaScriptCore/runtime/GetterSetter.h@ 47022

Last change on this file since 47022 was 47022, checked in by [email protected], 16 years ago

Stack overflow crash in JavaScript garbage collector mark pass
https://bugs.webkit.org/show_bug.cgi?id=12216

Reviewed by Gavin Barraclough and Sam Weinig

Make the GC mark phase iterative by using an explicit mark stack.
To do this marking any single object is performed in multiple stages

  • The object is appended to the MarkStack, this sets the marked bit for the object using the new markDirect() function, and then returns
  • When the MarkStack is drain()ed the object is popped off the stack and markChildren(MarkStack&) is called on the object to collect all of its children. drain() then repeats until the stack is empty.

Additionally I renamed a number of methods from 'mark' to 'markAggregate'
in order to make it more clear that marking of those object was not
going to result in an actual recursive mark.

  • Property svn:eol-style set to native
File size: 2.6 KB
Line 
1/*
2 * Copyright (C) 1999-2001 Harri Porten ([email protected])
3 * Copyright (C) 2001 Peter Kelly ([email protected])
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 *
6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version.
10 *
11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details.
15 *
16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA.
20 *
21 */
22
23#ifndef GetterSetter_h
24#define GetterSetter_h
25
26#include "JSCell.h"
27
28namespace JSC {
29
30 class JSObject;
31
32 // This is an internal value object which stores getter and setter functions
33 // for a property.
34 class GetterSetter : public JSCell {
35 public:
36 GetterSetter(ExecState* exec)
37 : JSCell(exec->globalData().getterSetterStructure.get())
38 , m_getter(0)
39 , m_setter(0)
40 {
41 }
42
43 virtual void markChildren(MarkStack&);
44
45 JSObject* getter() const { return m_getter; }
46 void setGetter(JSObject* getter) { m_getter = getter; }
47 JSObject* setter() const { return m_setter; }
48 void setSetter(JSObject* setter) { m_setter = setter; }
49 static PassRefPtr<Structure> createStructure(JSValue prototype)
50 {
51 return Structure::create(prototype, TypeInfo(GetterSetterType));
52 }
53 private:
54 virtual bool isGetterSetter() const;
55
56 virtual JSValue toPrimitive(ExecState*, PreferredPrimitiveType) const;
57 virtual bool getPrimitiveNumber(ExecState*, double& number, JSValue& value);
58 virtual bool toBoolean(ExecState*) const;
59 virtual double toNumber(ExecState*) const;
60 virtual UString toString(ExecState*) const;
61 virtual JSObject* toObject(ExecState*) const;
62
63 JSObject* m_getter;
64 JSObject* m_setter;
65 };
66
67 GetterSetter* asGetterSetter(JSValue);
68
69 inline GetterSetter* asGetterSetter(JSValue value)
70 {
71 ASSERT(asCell(value)->isGetterSetter());
72 return static_cast<GetterSetter*>(asCell(value));
73 }
74
75
76} // namespace JSC
77
78#endif // GetterSetter_h
Note: See TracBrowser for help on using the repository browser.