source: webkit/trunk/JavaScriptCore/runtime/JSAPIValueWrapper.h@ 47799

Last change on this file since 47799 was 47799, checked in by [email protected], 16 years ago

A bit of Collector refatoring.

Patch by Geoffrey Garen <[email protected]> on 2009-08-26
Reviewed by Oliver Hunt.

SunSpider says no change. v8 says 1.003x faster (1.02x faster on splay).

  • runtime/JSCell.cpp:

(JSC::JSCell::toPrimitive):
(JSC::JSCell::getPrimitiveNumber):
(JSC::JSCell::toBoolean):
(JSC::JSCell::toNumber):
(JSC::JSCell::toString):
(JSC::JSCell::toObject): Removed pure virtual functions from
JSCell, so the collector can construct one. This allowed
me to remove a bunch of ASSERT_NOT_REACHED throughout the
code, too.

  • runtime/JSCell.h:

(JSC::JSCell::JSCell): ditto
(JSC::Heap::heap): Inlined this function because it's trivial.

  • runtime/Collector.cpp:

(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks): Renamed freeHeap to freeBlocks, since
it doesn't actually free the Heap object.
(JSC::Heap::heapAllocate):
(JSC::Heap::sweep):

  • runtime/Collector.h: Refactored block allocation and destruction

into helper functions.

  • runtime/GetterSetter.cpp:
  • runtime/JSAPIValueWrapper.cpp:
  • runtime/JSPropertyNameIterator.cpp: Removed dummy implementations

of pure virtual functions. (See above.)

File size: 1.9 KB
Line 
1/*
2 * Copyright (C) 1999-2001 Harri Porten ([email protected])
3 * Copyright (C) 2001 Peter Kelly ([email protected])
4 * Copyright (C) 2003, 2004, 2005, 2007, 2008 Apple Inc. All rights reserved.
5 *
6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version.
10 *
11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details.
15 *
16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA.
20 *
21 */
22
23#ifndef JSAPIValueWrapper_h
24#define JSAPIValueWrapper_h
25
26#include <wtf/Platform.h>
27
28#include "JSCell.h"
29#include "CallFrame.h"
30
31namespace JSC {
32
33 class JSAPIValueWrapper : public JSCell {
34 friend JSValue jsAPIValueWrapper(ExecState*, JSValue);
35 public:
36 JSValue value() const { return m_value; }
37
38 virtual bool isAPIValueWrapper() const { return true; }
39
40 static PassRefPtr<Structure> createStructure(JSValue prototype)
41 {
42 return Structure::create(prototype, TypeInfo(CompoundType));
43 }
44
45
46 private:
47 JSAPIValueWrapper(ExecState* exec, JSValue value)
48 : JSCell(exec->globalData().apiWrapperStructure.get())
49 , m_value(value)
50 {
51 ASSERT(!value.isCell());
52 }
53
54 JSValue m_value;
55 };
56
57 inline JSValue jsAPIValueWrapper(ExecState* exec, JSValue value)
58 {
59 return new (exec) JSAPIValueWrapper(exec, value);
60 }
61
62} // namespace JSC
63
64#endif // JSAPIValueWrapper_h
Note: See TracBrowser for help on using the repository browser.