|
Last change
on this file since 48048 was 47022, checked in by [email protected], 16 years ago |
|
Stack overflow crash in JavaScript garbage collector mark pass
https://bugs.webkit.org/show_bug.cgi?id=12216
Reviewed by Gavin Barraclough and Sam Weinig
Make the GC mark phase iterative by using an explicit mark stack.
To do this marking any single object is performed in multiple stages
- The object is appended to the MarkStack, this sets the marked
bit for the object using the new markDirect() function, and then
returns
- When the MarkStack is drain()ed the object is popped off the stack
and markChildren(MarkStack&) is called on the object to collect
all of its children. drain() then repeats until the stack is empty.
Additionally I renamed a number of methods from 'mark' to 'markAggregate'
in order to make it more clear that marking of those object was not
going to result in an actual recursive mark.
|
-
Property svn:eol-style
set to
native
|
|
File size:
1.2 KB
|
| Line | |
|---|
| 1 | /*
|
|---|
| 2 | * Copyright (C) 2003, 2006, 2008, 2009 Apple Inc. All rights reserved.
|
|---|
| 3 | *
|
|---|
| 4 | * This library is free software; you can redistribute it and/or
|
|---|
| 5 | * modify it under the terms of the GNU Library General Public
|
|---|
| 6 | * License as published by the Free Software Foundation; either
|
|---|
| 7 | * version 2 of the License, or (at your option) any later version.
|
|---|
| 8 | *
|
|---|
| 9 | * This library is distributed in the hope that it will be useful,
|
|---|
| 10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|---|
| 11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|---|
| 12 | * Library General Public License for more details.
|
|---|
| 13 | *
|
|---|
| 14 | * You should have received a copy of the GNU Library General Public License
|
|---|
| 15 | * along with this library; see the file COPYING.LIB. If not, write to
|
|---|
| 16 | * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|---|
| 17 | * Boston, MA 02110-1301, USA.
|
|---|
| 18 | *
|
|---|
| 19 | */
|
|---|
| 20 |
|
|---|
| 21 | #ifndef ScopeChainMark_h
|
|---|
| 22 | #define ScopeChainMark_h
|
|---|
| 23 |
|
|---|
| 24 | #include "ScopeChain.h"
|
|---|
| 25 |
|
|---|
| 26 | namespace JSC {
|
|---|
| 27 |
|
|---|
| 28 | inline void ScopeChain::markAggregate(MarkStack& markStack) const
|
|---|
| 29 | {
|
|---|
| 30 | for (ScopeChainNode* n = m_node; n; n = n->next)
|
|---|
| 31 | markStack.append(n->object);
|
|---|
| 32 | }
|
|---|
| 33 |
|
|---|
| 34 | } // namespace JSC
|
|---|
| 35 |
|
|---|
| 36 | #endif // ScopeChainMark_h
|
|---|
Note:
See
TracBrowser
for help on using the repository browser.
