source: webkit/trunk/JavaScriptCore/runtime/TimeoutChecker.cpp@ 73091

Last change on this file since 73091 was 66475, checked in by [email protected], 15 years ago

2010-08-31 Benjamin Poulain <[email protected]>

Reviewed by Kenneth Rohde Christiansen.

JSC TimeoutChecker::didTimeOut overflows on ARM
https://bugs.webkit.org/show_bug.cgi?id=38538

Make getCPUTime() return values relative to the first call.
The previous implementation relied on simply on currentTime(), which
return a time since epoch and not a time since the thread started. This
made the return value of getCPUTime() overflow on 32 bits.

  • runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
File size: 5.3 KB
Line 
1/*
2 * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Cameron Zwarich <[email protected]>
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 *
9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer.
11 * 2. Redistributions in binary form must reproduce the above copyright
12 * notice, this list of conditions and the following disclaimer in the
13 * documentation and/or other materials provided with the distribution.
14 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
15 * its contributors may be used to endorse or promote products derived
16 * from this software without specific prior written permission.
17 *
18 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
19 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
20 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
21 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
22 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
23 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
24 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
25 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 */
29
30#include "config.h"
31#include "TimeoutChecker.h"
32
33#include "CallFrame.h"
34#include "JSGlobalObject.h"
35
36#if OS(DARWIN)
37#include <mach/mach.h>
38#elif OS(WINDOWS)
39#include <windows.h>
40#else
41#include "CurrentTime.h"
42#endif
43
44#if PLATFORM(BREWMP)
45#include <AEEStdLib.h>
46#endif
47
48using namespace std;
49
50namespace JSC {
51
52// Number of ticks before the first timeout check is done.
53static const int ticksUntilFirstCheck = 1024;
54
55// Number of milliseconds between each timeout check.
56static const int intervalBetweenChecks = 1000;
57
58// Returns the time the current thread has spent executing, in milliseconds.
59static inline unsigned getCPUTime()
60{
61#if OS(DARWIN)
62 mach_msg_type_number_t infoCount = THREAD_BASIC_INFO_COUNT;
63 thread_basic_info_data_t info;
64
65 // Get thread information
66 mach_port_t threadPort = mach_thread_self();
67 thread_info(threadPort, THREAD_BASIC_INFO, reinterpret_cast<thread_info_t>(&info), &infoCount);
68 mach_port_deallocate(mach_task_self(), threadPort);
69
70 unsigned time = info.user_time.seconds * 1000 + info.user_time.microseconds / 1000;
71 time += info.system_time.seconds * 1000 + info.system_time.microseconds / 1000;
72
73 return time;
74#elif OS(WINDOWS)
75 union {
76 FILETIME fileTime;
77 unsigned long long fileTimeAsLong;
78 } userTime, kernelTime;
79
80 // GetThreadTimes won't accept NULL arguments so we pass these even though
81 // they're not used.
82 FILETIME creationTime, exitTime;
83
84 GetThreadTimes(GetCurrentThread(), &creationTime, &exitTime, &kernelTime.fileTime, &userTime.fileTime);
85
86 return userTime.fileTimeAsLong / 10000 + kernelTime.fileTimeAsLong / 10000;
87#elif OS(SYMBIAN)
88 RThread current;
89 TTimeIntervalMicroSeconds cpuTime;
90
91 TInt err = current.GetCpuTime(cpuTime);
92 ASSERT_WITH_MESSAGE(err == KErrNone, "GetCpuTime failed with %d", err);
93 return cpuTime.Int64() / 1000;
94#elif PLATFORM(BREWMP)
95 // This function returns a continuously and linearly increasing millisecond
96 // timer from the time the device was powered on.
97 // There is only one thread in BREW, so this is enough.
98 return GETUPTIMEMS();
99#else
100 // FIXME: We should return the time the current thread has spent executing.
101
102 // use a relative time from first call in order to avoid an overflow
103 static double firstTime = currentTime();
104 return (currentTime() - firstTime) * 1000;
105#endif
106}
107
108TimeoutChecker::TimeoutChecker()
109 : m_timeoutInterval(0)
110 , m_startCount(0)
111{
112 reset();
113}
114
115void TimeoutChecker::reset()
116{
117 m_ticksUntilNextCheck = ticksUntilFirstCheck;
118 m_timeAtLastCheck = 0;
119 m_timeExecuting = 0;
120}
121
122bool TimeoutChecker::didTimeOut(ExecState* exec)
123{
124 unsigned currentTime = getCPUTime();
125
126 if (!m_timeAtLastCheck) {
127 // Suspicious amount of looping in a script -- start timing it
128 m_timeAtLastCheck = currentTime;
129 return false;
130 }
131
132 unsigned timeDiff = currentTime - m_timeAtLastCheck;
133
134 if (timeDiff == 0)
135 timeDiff = 1;
136
137 m_timeExecuting += timeDiff;
138 m_timeAtLastCheck = currentTime;
139
140 // Adjust the tick threshold so we get the next checkTimeout call in the
141 // interval specified in intervalBetweenChecks.
142 m_ticksUntilNextCheck = static_cast<unsigned>((static_cast<float>(intervalBetweenChecks) / timeDiff) * m_ticksUntilNextCheck);
143 // If the new threshold is 0 reset it to the default threshold. This can happen if the timeDiff is higher than the
144 // preferred script check time interval.
145 if (m_ticksUntilNextCheck == 0)
146 m_ticksUntilNextCheck = ticksUntilFirstCheck;
147
148 if (m_timeoutInterval && m_timeExecuting > m_timeoutInterval) {
149 if (exec->dynamicGlobalObject()->shouldInterruptScript())
150 return true;
151
152 reset();
153 }
154
155 return false;
156}
157
158} // namespace JSC
Note: See TracBrowser for help on using the repository browser.