source: webkit/trunk/JavaScriptCore/runtime/UStringImpl.cpp@ 54743

Last change on this file since 54743 was 54743, checked in by [email protected], 15 years ago

https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags

Reviewed by Darin Adler.

Remove UntypedPtrAndBitfield (similar to PtrAndFlags) in UStringImpl,
and steal bits from the refCount instead.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
(JSC::UStringImpl::):

File size: 3.7 KB
Line 
1/*
2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution.
12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25
26#include "config.h"
27#include "UStringImpl.h"
28
29#include "Identifier.h"
30#include "UString.h"
31#include <wtf/unicode/UTF8.h>
32
33using namespace WTF::Unicode;
34using namespace std;
35
36namespace JSC {
37
38PassRefPtr<UStringImpl> UStringImpl::create(const char* c)
39{
40 ASSERT(c);
41
42 if (!c[0])
43 return &UStringImpl::empty();
44
45 size_t length = strlen(c);
46 UChar* d;
47 PassRefPtr<UStringImpl> result = UStringImpl::createUninitialized(length, d);
48 for (size_t i = 0; i < length; i++)
49 d[i] = static_cast<unsigned char>(c[i]); // use unsigned char to zero-extend instead of sign-extend
50 return result;
51}
52
53PassRefPtr<UStringImpl> UStringImpl::create(const char* c, int length)
54{
55 ASSERT(c);
56
57 if (!length)
58 return &UStringImpl::empty();
59
60 UChar* d;
61 PassRefPtr<UStringImpl> result = UStringImpl::createUninitialized(length, d);
62 for (int i = 0; i < length; i++)
63 d[i] = static_cast<unsigned char>(c[i]); // use unsigned char to zero-extend instead of sign-extend
64 return result;
65}
66
67PassRefPtr<UStringImpl> UStringImpl::create(const UChar* buffer, int length)
68{
69 UChar* newBuffer;
70 PassRefPtr<UStringImpl> impl = createUninitialized(length, newBuffer);
71 copyChars(newBuffer, buffer, length);
72 return impl;
73}
74
75SharedUChar* UStringImpl::baseSharedBuffer()
76{
77 ASSERT((bufferOwnership() == BufferShared)
78 || ((bufferOwnership() == BufferOwned) && !m_buffer));
79
80 if (bufferOwnership() != BufferShared) {
81 m_refCountAndFlags = (m_refCountAndFlags & ~s_refCountMaskBufferOwnership) | BufferShared;
82 m_bufferShared = SharedUChar::create(new OwnFastMallocPtr<UChar>(m_data)).releaseRef();
83 }
84
85 return m_bufferShared;
86}
87
88SharedUChar* UStringImpl::sharedBuffer()
89{
90 if (m_length < s_minLengthToShare)
91 return 0;
92 ASSERT(!isStatic());
93
94 UStringImpl* owner = bufferOwnerString();
95 if (owner->bufferOwnership() == BufferInternal)
96 return 0;
97
98 return owner->baseSharedBuffer();
99}
100
101UStringImpl::~UStringImpl()
102{
103 ASSERT(!isStatic());
104 checkConsistency();
105
106 if (isIdentifier())
107 Identifier::remove(this);
108
109 if (bufferOwnership() != BufferInternal) {
110 if (bufferOwnership() == BufferOwned)
111 fastFree(m_data);
112 else if (bufferOwnership() == BufferSubstring)
113 m_bufferSubstring->deref();
114 else {
115 ASSERT(bufferOwnership() == BufferShared);
116 m_bufferShared->deref();
117 }
118 }
119}
120
121}
Note: See TracBrowser for help on using the repository browser.