source: webkit/trunk/Source/JavaScriptCore/dfg/DFGDesiredIdentifiers.cpp

Last change on this file was 276005, checked in by [email protected], 4 years ago

[JSC] Change Vector<> to FixedVector<> in DFG::CommonData if possible
https://bugs.webkit.org/show_bug.cgi?id=224588

Reviewed by Mark Lam.

DFG::CommonData is kept alive so long as DFG code exists. It includes a lot of Vectors while they are not mutable after the DFG code compilation.
This patch changes Vector<> to FixedVector<> if possible to shrink sizeof(DFG::CommonData). And this also removes the need of calling shrinkToFit
explicitly for them.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::numberOfDFGIdentifiers const):
(JSC::CodeBlock::identifier const):

  • bytecode/CodeBlock.h:
  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::shrinkToFit):
(JSC::DFG::CommonData::invalidate):
(JSC::DFG::CommonData::~CommonData):
(JSC::DFG::CommonData::installVMTrapBreakpoints):
(JSC::DFG::CommonData::isVMTrapBreakpoint):
(JSC::DFG::CommonData::finalizeCatchEntrypoints):
(JSC::DFG::CommonData::notifyCompilingStructureTransition): Deleted.

  • dfg/DFGCommonData.h:

(JSC::DFG::CommonData::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::CommonData::appendCatchEntrypoint): Deleted.

  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::DesiredTransition):
(JSC::DFG::DesiredTransitions::DesiredTransitions):
(JSC::DFG::DesiredTransitions::addLazily):
(JSC::DFG::DesiredTransitions::reallyAdd):
(JSC::DFG::DesiredTransition::reallyAdd): Deleted.

  • dfg/DFGDesiredTransitions.h:
  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::reallyAdd):

  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::noticeCatchEntrypoint):

  • dfg/DFGOSREntry.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkOSREntries):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutStructure):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileInvalidationPoint):

File size: 3.5 KB
Line 
1/*
2 * Copyright (C) 2013-2020 Apple Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution.
12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25
26#include "config.h"
27#include "DFGDesiredIdentifiers.h"
28
29#if ENABLE(DFG_JIT)
30
31#include "CodeBlock.h"
32#include "DFGCommonData.h"
33#include "IdentifierInlines.h"
34
35namespace JSC { namespace DFG {
36
37DesiredIdentifiers::DesiredIdentifiers()
38 : m_codeBlock(nullptr)
39 , m_didProcessIdentifiers(false)
40{
41}
42
43DesiredIdentifiers::DesiredIdentifiers(CodeBlock* codeBlock)
44 : m_codeBlock(codeBlock)
45 , m_didProcessIdentifiers(false)
46{
47}
48
49DesiredIdentifiers::~DesiredIdentifiers()
50{
51}
52
53unsigned DesiredIdentifiers::numberOfIdentifiers()
54{
55 return m_codeBlock->numberOfIdentifiers() + m_addedIdentifiers.size();
56}
57
58unsigned DesiredIdentifiers::ensure(UniquedStringImpl* rep)
59{
60 if (!m_didProcessIdentifiers) {
61 // Do this now instead of the constructor so that we don't pay the price on the main
62 // thread. Also, not all compilations need to call ensure().
63 for (unsigned index = m_codeBlock->numberOfIdentifiers(); index--;)
64 m_identifierNumberForName.add(m_codeBlock->identifier(index).impl(), index);
65 m_didProcessIdentifiers = true;
66 }
67
68 auto addResult = m_identifierNumberForName.add(rep, numberOfIdentifiers());
69 unsigned result = addResult.iterator->value;
70 if (addResult.isNewEntry) {
71 m_addedIdentifiers.append(rep);
72 ASSERT(at(result) == rep);
73 }
74 return result;
75}
76
77UniquedStringImpl* DesiredIdentifiers::at(unsigned index) const
78{
79 UniquedStringImpl* result;
80 if (index < m_codeBlock->numberOfIdentifiers())
81 result = m_codeBlock->identifier(index).impl();
82 else
83 result = m_addedIdentifiers[index - m_codeBlock->numberOfIdentifiers()];
84 ASSERT(result->hasAtLeastOneRef());
85 return result;
86}
87
88void DesiredIdentifiers::reallyAdd(VM& vm, CommonData* commonData)
89{
90 unsigned index = 0;
91 FixedVector<Identifier> identifiers(m_addedIdentifiers.size());
92 for (auto rep : m_addedIdentifiers) {
93 ASSERT(rep->hasAtLeastOneRef());
94 identifiers[index++] = Identifier::fromUid(vm, rep);
95 }
96 if (!identifiers.isEmpty()) {
97 ConcurrentJSLocker locker(m_codeBlock->m_lock);
98 ASSERT(commonData->m_dfgIdentifiers.isEmpty());
99 commonData->m_dfgIdentifiers = WTFMove(identifiers);
100 }
101}
102
103} } // namespace JSC::DFG
104
105#endif // ENABLE(DFG_JIT)
106
Note: See TracBrowser for help on using the repository browser.