source: webkit/trunk/Source/JavaScriptCore/dfg/DFGUnificationPhase.cpp

Last change on this file was 283623, checked in by [email protected], 4 years ago

Run backwards propagation before we prune the graph after ForceOSRExit nodes in BytecodeParser
https://bugs.webkit.org/show_bug.cgi?id=230823
<rdar://problem/83565088>

Reviewed by Robin Morisset.

JSTests:

  • run-backwards-propagation-before-osr-exit-pruning.js: Added.

(assert):
(main.async v24):
(main):

Source/JavaScriptCore:

We've found yet another bug where pruning code after OSR exits
before running backwards propagation leads to us breaking the spec
in weird IR situations. In the particular test case here, we end
up not thinking we care about negative zero for an ArithNegate,
and we exit the program while recovering the value 0 instead of -0.

Fundamentally, backwards propagation wants to see all bytecode uses.
Therefore, it seems like a more sound strategy to run backwards propagation
before we end up mucking with the graph. This patch makes it so we run
backwards propagation inside bytecode parser before we prune the IR.
That way, the phase sees the graph as if it's an IR over the whole bytecode
graph.

  • bytecode/Operands.h:

(JSC::Operands::operator!= const):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::run):
(JSC::DFG::BackwardsPropagationPhase::mergeFlags):
(JSC::DFG::BackwardsPropagationPhase::propagate):
(JSC::DFG::performBackwardsPropagation):

  • dfg/DFGBackwardsPropagationPhase.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGUnificationPhase.cpp:

(JSC::DFG::UnificationPhase::run):

File size: 3.7 KB
Line 
1/*
2 * Copyright (C) 2013, 2015 Apple Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution.
12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25
26#include "config.h"
27#include "DFGUnificationPhase.h"
28
29#if ENABLE(DFG_JIT)
30
31#include "DFGGraph.h"
32#include "DFGPhase.h"
33#include "JSCJSValueInlines.h"
34
35namespace JSC { namespace DFG {
36
37class UnificationPhase : public Phase {
38public:
39 UnificationPhase(Graph& graph)
40 : Phase(graph, "unification")
41 {
42 }
43
44 bool run()
45 {
46 ASSERT(m_graph.m_form == ThreadedCPS);
47 ASSERT(m_graph.m_unificationState == LocallyUnified);
48
49 // Ensure that all Phi functions are unified.
50 for (BlockIndex blockIndex = m_graph.numBlocks(); blockIndex--;) {
51 BasicBlock* block = m_graph.block(blockIndex);
52 if (!block)
53 continue;
54 ASSERT(block->isReachable);
55
56 for (unsigned phiIndex = block->phis.size(); phiIndex--;) {
57 Node* phi = block->phis[phiIndex];
58 for (unsigned childIdx = 0; childIdx < AdjacencyList::Size; ++childIdx) {
59 if (!phi->children.child(childIdx))
60 break;
61
62 // FIXME: Consider reversing the order of this unification, since the other
63 // order will reveal more bugs. https://bugs.webkit.org/show_bug.cgi?id=154368
64 phi->variableAccessData()->unify(phi->children.child(childIdx)->variableAccessData());
65 }
66 }
67 }
68
69 // Ensure that all predictions are fixed up based on the unification.
70 for (unsigned i = 0; i < m_graph.m_variableAccessData.size(); ++i) {
71 VariableAccessData* data = &m_graph.m_variableAccessData[i];
72 data->find()->predict(data->nonUnifiedPrediction());
73 data->find()->mergeStructureCheckHoistingFailed(data->structureCheckHoistingFailed());
74 data->find()->mergeCheckArrayHoistingFailed(data->checkArrayHoistingFailed());
75 data->find()->mergeShouldNeverUnbox(data->shouldNeverUnbox());
76 data->find()->mergeIsLoadedFrom(data->isLoadedFrom());
77 data->find()->mergeIsProfitableToUnbox(data->isProfitableToUnbox());
78 data->find()->mergeFlags(data->flags());
79 }
80
81 m_graph.m_unificationState = GloballyUnified;
82 return true;
83 }
84};
85
86bool performUnification(Graph& graph)
87{
88 return runPhase<UnificationPhase>(graph);
89}
90
91} } // namespace JSC::DFG
92
93#endif // ENABLE(DFG_JIT)
94
Note: See TracBrowser for help on using the repository browser.