source: webkit/trunk/Source/JavaScriptCore/jit/CallFrameShuffleData.cpp

Last change on this file was 294794, checked in by [email protected], 3 years ago

[JSC][ARMv7] Support callee save FPRs

Patch by Geza Lore <Geza Lore> on 2022-05-25
https://bugs.webkit.org/show_bug.cgi?id=240376

Reviewed by Yusuke Suzuki.

ARMv7 FPRs d8-d15 (also referenced as s16-s32 and q4-q7) are callee save
in the host ABI, but currently JSC is unaware of this. This does not
currently cause problems as they are not used, but will be used by the
Wasm JITs.

In preparation for the 32-bit ports of the Wasm JITs, this patch:

  • Teaches JSC about callee save FPRs on ARMv7. d8-d15 are host ABI callee save, but only d8-d14 are VM callee save, i.e.: we treat d15 as a volatile register in JIT code. This is so we can use d15 as a macro assembler scratch register.
  • Changes offlineasm and MacroAssemblerARMv7 to use d15 as the FP scratch register. We do this so we can use the full range of d0-d7 as temporary, and in particular as Wasm argument/return registers.
  • To achieve the above, we need to modify RegisterAtOffsetList as GPRs and FPRs have different sizes on JSVALUE32_64 platforms
  • Adds the ARMv7 specific registers to RegisterSet::macroScratchRegisters()
  • assembler/ARMv7Registers.h:
  • assembler/MacroAssemblerARMv7.h:
  • b3/air/AirCode.cpp:

(JSC::B3::Air::Code::calleeSaveRegisterAtOffsetList const):
(JSC::B3::Air::Code::dump const):

  • b3/testb3_7.cpp:

(testInfiniteLoopDoesntCauseBadHoisting):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
(JSC::roundCalleeSaveSpaceAsVirtualRegisters): Deleted.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::calleeSaveGPRDisplacedInJSStack):
(JSC::ValueRecovery::calleeSaveRegDisplacedInJSStack): Deleted.

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::calleeSaveSlot):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::copyCalleeSavesToEntryFrameCalleeSavesBuffer const):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::restoreCalleeSavesFromEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMEntryFrameCalleeSavesBufferImpl):
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBufferImpl):
(JSC::AssemblyHelpers::emitSave):
(JSC::AssemblyHelpers::emitRestore):
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::emitSaveOrCopyLLIntBaselineCalleeSavesFor):

  • jit/CallFrameShuffleData.cpp:

(JSC::CallFrameShuffleData::setupCalleeSaveRegisters):

  • jit/CallFrameShuffler.h:

(JSC::CallFrameShuffler::snapshot const):

  • jit/CallFrameShuffler32_64.cpp:

(JSC::CallFrameShuffler::emitDisplace):

  • jit/FPRInfo.h:
  • jit/GPRInfo.h:
  • jit/RegisterAtOffsetList.cpp:

(JSC::RegisterAtOffsetList::RegisterAtOffsetList):

  • jit/RegisterAtOffsetList.h:

(JSC::RegisterAtOffsetList::registerCount const):
(JSC::RegisterAtOffsetList::sizeOfAreaInBytes const):
(JSC::RegisterAtOffsetList::adjustOffsets):
(JSC::RegisterAtOffsetList::size const): Deleted.
(JSC::RegisterAtOffsetList::at): Deleted.

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::macroScratchRegisters):
(JSC::RegisterSet::vmCalleeSaveRegisters):

  • llint/LowLevelInterpreter.asm:
  • offlineasm/arm.rb:
  • wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

  • wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

Canonical link: https://commits.webkit.org/250952@main

File size: 4.8 KB
Line 
1/*
2 * Copyright (C) 2015 Apple Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution.
12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25
26#include "config.h"
27#include "CallFrameShuffleData.h"
28
29#if ENABLE(JIT)
30
31#include "BaselineJITRegisters.h"
32#include "BytecodeStructs.h"
33#include "CodeBlock.h"
34#include "RegisterAtOffsetList.h"
35
36namespace JSC {
37
38void CallFrameShuffleData::setupCalleeSaveRegisters(const RegisterAtOffsetList* registerSaveLocations)
39{
40 RegisterSet calleeSaveRegisters { RegisterSet::vmCalleeSaveRegisters() };
41
42 for (size_t i = 0; i < registerSaveLocations->registerCount(); ++i) {
43 RegisterAtOffset entry { registerSaveLocations->at(i) };
44 if (!calleeSaveRegisters.get(entry.reg()))
45 continue;
46
47 int saveSlotIndexInCPURegisters = entry.offsetAsIndex();
48
49#if USE(JSVALUE64)
50 // CPU registers are the same size as virtual registers
51 VirtualRegister saveSlot { saveSlotIndexInCPURegisters };
52 registers[entry.reg()]
53 = ValueRecovery::displacedInJSStack(saveSlot, DataFormatJS);
54#elif USE(JSVALUE32_64)
55 // On 32-bit architectures, 2 callee saved GPRs may be packed into the same slot
56 if (entry.reg().isGPR()) {
57 static_assert(!PayloadOffset || !TagOffset);
58 static_assert(PayloadOffset == 4 || TagOffset == 4);
59 bool inTag = (saveSlotIndexInCPURegisters & 1) == !!TagOffset;
60 if (saveSlotIndexInCPURegisters < 0)
61 saveSlotIndexInCPURegisters -= 1; // Round towards -inf
62 VirtualRegister saveSlot { saveSlotIndexInCPURegisters / 2 };
63 registers[entry.reg()] = ValueRecovery::calleeSaveGPRDisplacedInJSStack(saveSlot, inTag);
64 } else {
65 ASSERT(!(saveSlotIndexInCPURegisters & 1)); // Should be at an even offset
66 VirtualRegister saveSlot { saveSlotIndexInCPURegisters / 2 };
67 registers[entry.reg()] = ValueRecovery::displacedInJSStack(saveSlot, DataFormatDouble);
68 }
69#endif
70 }
71
72 for (Reg reg = Reg::first(); reg <= Reg::last(); reg = reg.next()) {
73 if (!calleeSaveRegisters.get(reg))
74 continue;
75
76 if (registers[reg])
77 continue;
78
79#if USE(JSVALUE64)
80 registers[reg] = ValueRecovery::inRegister(reg, DataFormatJS);
81#elif USE(JSVALUE32_64)
82 registers[reg] = ValueRecovery::inRegister(reg, reg.isGPR() ? DataFormatInt32 : DataFormatDouble);
83#endif
84 }
85}
86
87CallFrameShuffleData CallFrameShuffleData::createForBaselineOrLLIntTailCall(const OpTailCall& bytecode, unsigned numParameters)
88{
89 CallFrameShuffleData shuffleData;
90 shuffleData.numPassedArgs = bytecode.m_argc;
91 shuffleData.numParameters = numParameters;
92#if USE(JSVALUE64)
93 shuffleData.numberTagRegister = GPRInfo::numberTagRegister;
94#endif
95 shuffleData.numLocals = bytecode.m_argv - sizeof(CallerFrameAndPC) / sizeof(Register);
96 shuffleData.args.resize(bytecode.m_argc);
97 for (unsigned i = 0; i < bytecode.m_argc; ++i) {
98 shuffleData.args[i] =
99 ValueRecovery::displacedInJSStack(
100 virtualRegisterForArgumentIncludingThis(i) - bytecode.m_argv,
101 DataFormatJS);
102 }
103#if USE(JSVALUE64)
104 shuffleData.callee = ValueRecovery::inGPR(BaselineJITRegisters::Call::calleeJSR.payloadGPR(), DataFormatJS);
105#elif USE(JSVALUE32_64)
106 shuffleData.callee = ValueRecovery::inPair(BaselineJITRegisters::Call::calleeJSR.tagGPR(), BaselineJITRegisters::Call::calleeJSR.payloadGPR());
107#endif
108 shuffleData.setupCalleeSaveRegisters(&RegisterAtOffsetList::llintBaselineCalleeSaveRegisters());
109 shuffleData.shrinkToFit();
110 return shuffleData;
111}
112
113} // namespace JSC
114
115#endif // ENABLE(JIT)
Note: See TracBrowser for help on using the repository browser.