source: webkit/trunk/Source/WebCore/css/CSSValuePair.cpp

Last change on this file was 274566, checked in by [email protected], 4 years ago

Use ASCIILiteral over String for CSSValue::separatorCSSText() to avoid allocation
https://bugs.webkit.org/show_bug.cgi?id=223300

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-03-17
Reviewed by Yusuke Suzuki.

Use ASCIILiteral over String for CSSValue::separatorCSSText() to avoid
allocation, since we know this function will always return an
ASCII string. Also rename separatorCssText to separatorCSSText.

These changes were requested in this comment:
https://bugs.webkit.org/show_bug.cgi?id=223205#c8

  • css/CSSValue.cpp:

(WebCore::CSSValue::separatorCSSText const):
(WebCore::CSSValue::separatorCssText const):
Rename function separatorCssText to separatorCSSText.

  • css/CSSValue.h:

String CSSValue::separatorCssText --> ASCIILiteral CSSValue::separatorCSSText

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::customCSSText const):
Use auto to capture result of separatorCSSText().

  • css/CSSValuePair.cpp:

(WebCore::CSSValuePair::customCSSText const):
Function separatorCssText was renamed to separatorCSSText.

File size: 1.9 KB
Line 
1/*
2 * Copyright (C) 2021 Tyler Wilcock <[email protected]>.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions
6 * are met:
7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution.
12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25
26#include "config.h"
27#include "CSSValuePair.h"
28
29#include <wtf/text/StringBuilder.h>
30
31namespace WebCore {
32
33String CSSValuePair::customCSSText() const
34{
35 String first = this->first()->cssText();
36 String second = this->second()->cssText();
37 if (m_encoding == IdenticalValueEncoding::Coalesce && first == second)
38 return first;
39 return makeString(first, separatorCSSText(), second);
40}
41
42bool CSSValuePair::equals(const CSSValuePair &other) const
43{
44 return m_valueSeparator == other.m_valueSeparator && m_first.get().equals(other.m_first) && m_second.get().equals(other.m_second);
45}
46
47} // namespace WebCore
Note: See TracBrowser for help on using the repository browser.