Changeset 102038 in webkit for trunk/Source/JavaScriptCore/assembler

Timestamp:

Dec 5, 2011, 1:25:18 PM (13 years ago)

Author:

[email protected]

Message:

Unreviewed, build fixes for ARM.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::unreachableForPlatform):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

Location:

trunk/Source/JavaScriptCore/assembler

Files:

• AbstractMacroAssembler.h (modified) (1 diff)
• MacroAssemblerARMv7.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/assembler/AbstractMacroAssembler.h

@@ -598 +598 @@
         return AssemblerType::readPointer(dataLabelPtr.dataLocation());
     }
+    
+    static void unreachableForPlatform()
+    {
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wmissing-noreturn"
+        ASSERT_NOT_REACHED();
+#pragma clang diagnostic pop
+#else
+        ASSERT_NOT_REACHED();
+#endif
+    }
 };
 

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h

@@ -714 +714 @@
     void loadDouble(BaseIndex address, FPRegisterID dest)
     {
-        ASSERT_NOT_REACHED();
+        UNUSED_PARAM(address);
+        UNUSED_PARAM(dest);
+        unreachableForPlatform();
     }
     
     void loadFloat(BaseIndex address, FPRegisterID dest)
     {
-        ASSERT_NOT_REACHED();
+        UNUSED_PARAM(address);
+        UNUSED_PARAM(dest);
+        unreachableForPlatform();
     }
 
@@ -766 +770 @@
         move(address.index, addressTempRegister);
         mul32(TrustedImm32(address.scale), addressTempRegister, addressTempRegister);
-        storeDouble(ARMRegisters::asSingle(src), Address(addressTempRegister, address.offset));
+        storeDouble(src, Address(addressTempRegister, address.offset));
     }
 
@@ -867 +871 @@
     void convertFloatToDouble(FPRegisterID src, FPRegisterID dst)
     {
-        ASSERT_NOT_REACHED();
+        UNUSED_PARAM(src);
+        UNUSED_PARAM(dst);
+        unreachableForPlatform();
     }
     
     void convertDoubleToFloat(FPRegisterID src, FPRegisterID dst)
     {
-        ASSERT_NOT_REACHED();
+        UNUSED_PARAM(src);
+        UNUSED_PARAM(dst);
+        unreachableForPlatform();
     }