Changeset 106370 in webkit for trunk/Source/JavaScriptCore/assembler

Timestamp:

Jan 31, 2012, 11:07:44 AM (13 years ago)

Author:

[email protected]

Message:

ASSERT(m_jumpsToLink.isEmpty()) failing in ARMv7Assembler dtor
​https://bugs.webkit.org/show_bug.cgi?id=77443

Reviewed by Gavin Barraclough.

Removed failing ASSERT() and thus destructor. The ASSERT isn't needed.
We are hitting it in the YARR JIT case where we bail out and go to the
interpreter with a partially JIT'ed function. Since we haven't linked
the JIT'ed code, there is likely to be some unresolved jumps in the vector
when the ARMv7Assembler destructor is called. For the case where we
complete the JIT process, we clear the vector at the end of
LinkBuffer::linkCode (LinkBuffer.h:292).

• assembler/ARMv7Assembler.h:

(ARMv7Assembler):

File:

• trunk/Source/JavaScriptCore/assembler/ARMv7Assembler.h (modified) (1 diff)

trunk/Source/JavaScriptCore/assembler/ARMv7Assembler.h

@@ -415 +415 @@
 class ARMv7Assembler {
 public:
-    ~ARMv7Assembler()
-    {
-        ASSERT(m_jumpsToLink.isEmpty());
-    }
-
     typedef ARMRegisters::RegisterID RegisterID;
     typedef ARMRegisters::FPSingleRegisterID FPSingleRegisterID;