Changeset 10655 in webkit for trunk/JavaScriptCore

Timestamp:

Sep 28, 2005, 6:55:11 PM (20 years ago)

Author:

ggaren

Message:

• Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by darin.

• kjs/date_object.cpp: (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning invalidDate, substitute the local timezone. This matches the behavior of FF/IE.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/date_object.cpp (modified) (5 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2005-09-28  Geoffrey Garen  <[email protected]>
+
+        - Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display 
+          "NAN/Undefined" for www.washingtonpost.com
+          
+        Reviewed by darin.
+
+        * kjs/date_object.cpp:
+        (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning
+        invalidDate, substitute the local timezone. This matches the behavior of FF/IE.
+
 2005-09-28  Maciej Stachowiak  <[email protected]>
 

trunk/JavaScriptCore/kjs/date_object.cpp

@@ -387 +387 @@
 }
 
-static double timeZoneOffset(const struct tm *t)
+static long timeZoneOffset(const struct tm *t)
 {
 #if defined BSD || defined(__linux__) || defined(__APPLE__)
@@ -1092 +1092 @@
      //
      double result = -1;
-     int offset = 0;
+     long offset = 0;
      bool have_tz = false;
      char *newPosStr;
@@ -1301 +1301 @@
      }
 
-     // don't fail if the time zone is missing, some
-     // broken mail-/news-clients omit the time zone
      if (*dateString) {
        if (strncasecmp(dateString, "GMT", 3) == 0 ||
@@ -1345 +1343 @@
            }
          }
-         // Bail out if we found an unknown timezone
-         if (!have_tz)
+         // If the time zone is missing or malformed, substitute the local time zone. 
+         // Some websites (4275206) omit the time zone.
+         if (!have_tz) {
+           time_t now;
+           struct tm t;
+           
+           time(&now);
+           if (now == -1)
              return invalidDate;
+           
+           localtime_r(&now, &t);
+           offset = -timeZoneOffset(&t);
+           
+           have_tz = true;
+         }
        }
      }
@@ -1385 +1395 @@
      }
      
-     result = ymdhms_to_seconds(year, month+1, day, hour, minute, second) - (offset*60);
+     result = ymdhms_to_seconds(year, month+1, day, hour, minute, second) - (offset * 60);
      return result;
 }