Changeset 112164 in webkit for trunk/Source/JavaScriptCore/bytecode

Timestamp:

Mar 26, 2012, 3:58:35 PM (13 years ago)

Author:

[email protected]

Message:

DFG should assert that argument value recoveries can only be
AlreadyInRegisterFile or Constant
​https://bugs.webkit.org/show_bug.cgi?id=82249

Reviewed by Michael Saboff.

Made the assertions that the DFG makes for argument value recoveries match
what Arguments expects.

• bytecode/ValueRecovery.h:

(JSC::ValueRecovery::isConstant):
(ValueRecovery):
(JSC::ValueRecovery::isAlreadyInRegisterFile):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

File:

• trunk/Source/JavaScriptCore/bytecode/ValueRecovery.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/bytecode/ValueRecovery.h

@@ -193 +193 @@
     ValueRecoveryTechnique technique() const { return m_technique; }
     
+    bool isConstant() const { return m_technique == Constant; }
+    
     bool isInRegisters() const
     {
@@ -209 +211 @@
     }
     
+    bool isAlreadyInRegisterFile() const
+    {
+        switch (technique()) {
+        case AlreadyInRegisterFile:
+        case AlreadyInRegisterFileAsUnboxedInt32:
+        case AlreadyInRegisterFileAsUnboxedCell:
+        case AlreadyInRegisterFileAsUnboxedBoolean:
+        case AlreadyInRegisterFileAsUnboxedDouble:
+            return true;
+        default:
+            return false;
+        }
+    }
+    
     MacroAssembler::RegisterID gpr() const
     {