Changeset 114185 in webkit for trunk/Source/JavaScriptCore/tests

Timestamp:

Apr 13, 2012, 5:26:25 PM (13 years ago)

Author:

[email protected]

Message:

Array.prototype.toString and Array.prototype.toLocaleString should be generic
​https://bugs.webkit.org/show_bug.cgi?id=81588

Patch by Hojong Han <​[email protected]> on 2012-04-13
Reviewed by Gavin Barraclough.

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

• runtime/CommonIdentifiers.h:
• tests/mozilla/ecma/Array/15.4.4.2.js:

(getTestCases.array.item.new.TestCase):
(getTestCases):

File:

• trunk/Source/JavaScriptCore/tests/mozilla/ecma/Array/15.4.4.2.js (modified) (2 diffs)

trunk/Source/JavaScriptCore/tests/mozilla/ecma/Array/15.4.4.2.js

@@ -56 +56 @@
     array[item++] = new TestCase( SECTION,  "(new Array(void 0,null)).toString()",    ",",    (new Array(void 0,null)).toString() );
 
+    array[item++] = new TestCase( SECTION,
+                                  "{__proto__: Array.prototype, 0: 'a', 1: 'b', 2: 'c', length: 3}.toString()",
+                                  "a,b,c",
+                                  {__proto__: Array.prototype, 0: 'a', 1: 'b', 2: 'c', length: 3}.toString() );
+    array[item++] = new TestCase( SECTION,
+                                  "{__proto__: Array.prototype, 0: 'a', 1: 'b', 2: 'c', join: function() { return 'join' }}.toString()",
+                                  "join",
+                                  {__proto__: Array.prototype, 0: 'a', 1: 'b', 2: 'c', join: function() { return 'join' }}.toString() );
+    array[item++] = new TestCase( SECTION,
+                                  "Array.prototype.toString.call({join: function() { return 'join' }})",
+                                  "join",
+                                  Array.prototype.toString.call({join: function() { return 'join' }}) );
+    array[item++] = new TestCase( SECTION,
+                                  "Array.prototype.toString.call({sort: function() { return 'sort' }})",
+                                  "[object Object]",
+                                  Array.prototype.toString.call({sort: function() { return 'sort' }}) );
+    array[item++] = new TestCase( SECTION,
+                                  "Array.prototype.toString.call(new Date)",
+                                  "[object Date]", 
+                                  Array.prototype.toString.call(new Date) );
+    array[item++] = new TestCase( SECTION,
+                                  "Number.prototype.join = function() { return 'number join' }; Array.prototype.toString.call(42)",
+                                  "number join",
+                                  eval("Number.prototype.join = function() { return 'number join' }; Array.prototype.toString.call(42)") );
+
     var EXPECT_STRING = "";
     var MYARR = new Array();
@@ -68 +93 @@
     array[item++] = new TestCase( SECTION, "MYARR.toString()",  EXPECT_STRING,  MYARR.toString() );
 
+    array[item++] = new TestCase( SECTION,
+                                  "Array.prototype.join = function() { return 'join' }; [0, 1, 2].toString()",
+                                  "join",
+                                  eval("Array.prototype.join = function() { return 'join' }; [0, 1, 2].toString()") );
 
     return ( array );