Changeset 114695 in webkit for trunk/Source/JavaScriptCore/assembler

Timestamp:

Apr 19, 2012, 4:52:46 PM (13 years ago)

Author:

[email protected]

Message:

MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
​https://bugs.webkit.org/show_bug.cgi?id=84401

Reviewed by Gavin Barraclough.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h (modified) (1 diff)

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h

@@ -996 +996 @@
         m_assembler.vcvt_floatingPointToSigned(fpTempRegisterAsSingle(), src);
         m_assembler.vmov(dest, fpTempRegisterAsSingle());
-
-        return branch32(branchType ? GreaterThanOrEqual : LessThan, dest, TrustedImm32(0));
+        
+        Jump overflow = branch32(Equal, dest, TrustedImm32(0x7fffffff));
+        Jump success = branch32(GreaterThanOrEqual, dest, TrustedImm32(0));
+        overflow.link(this);
+
+        if (branchType == BranchIfTruncateSuccessful)
+            return success;
+        
+        Jump failure = jump();
+        success.link(this);
+        return failure;
     }