Changeset 121374 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Jun 27, 2012, 2:45:08 PM (13 years ago)

Author:

[email protected]

Message:

x86 disassembler confuses immediates with addresses
​https://bugs.webkit.org/show_bug.cgi?id=90099

Reviewed by Mark Hahnenberg.

Prepend "$" to immediates to disambiguate between immediates and addresses. This is in
accordance with the gas and AT&T syntax.

• disassembler/udis86/udis86_syn-att.c:

(gen_operand):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• disassembler/udis86/udis86_syn-att.c (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-06-27  Filip Pizlo  <[email protected]>
+
+        x86 disassembler confuses immediates with addresses
+        https://bugs.webkit.org/show_bug.cgi?id=90099
+
+        Reviewed by Mark Hahnenberg.
+        
+        Prepend "$" to immediates to disambiguate between immediates and addresses. This is in
+        accordance with the gas and AT&T syntax.
+
+        * disassembler/udis86/udis86_syn-att.c:
+        (gen_operand):
+
 2012-06-27  Filip Pizlo  <[email protected]>
 

trunk/Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c

@@ -110 +110 @@
         if ( sext_size < 64 )
             sext_mask = ( 1ull << sext_size ) - 1;
-        mkasm( u, "0x" FMT64 "x", imm & sext_mask ); 
+        mkasm( u, "$0x" FMT64 "x", imm & sext_mask ); 
 
                 break;