Changeset 12512 in webkit for trunk/JavaScriptCore

Timestamp:

Jan 31, 2006, 10:24:32 PM (19 years ago)

Author:

mjs

Message:

Reviewed by Darin.

• fixed leak of hundreds of thousands of JS parser nodes on the layout tests, and added an exit counter that would catch them

• kjs/nodes.cpp: (NodeCounter::~NodeCounter): Added debug-only node counter. (Node::Node): (Node::~Node):
• kxmlcore/VectorTraits.h: Simple classes like RefPtr do in fact need destruction.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/nodes.cpp (modified) (2 diffs)
• kxmlcore/VectorTraits.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2006-01-31  Maciej Stachowiak  <[email protected]>
+
+        Reviewed by Darin.
+        
+        - fixed leak of hundreds of thousands of JS parser nodes on the layout tests, and added an exit counter
+        that would catch them
+
+        * kjs/nodes.cpp:
+        (NodeCounter::~NodeCounter): Added debug-only node counter.
+        (Node::Node):
+        (Node::~Node):
+        * kxmlcore/VectorTraits.h: Simple classes like RefPtr do in fact need destruction.
+
 2006-01-31  Darin Adler  <[email protected]>
 

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -86 +86 @@
 // ------------------------------ Node -----------------------------------------
 
+
+#ifndef NDEBUG
+struct NodeCounter { 
+    static int count; 
+    ~NodeCounter() { if (count != 0) fprintf(stderr, "LEAK: %d KJS::Node\n", count); }
+};
+int NodeCounter::count = 0;
+static NodeCounter nodeImplCounter;
+#endif NDEBUG
+
+
 Node::Node()
 {
+#ifndef NDEBUG
+    ++NodeCounter::count;
+#endif
   line = Lexer::curr()->lineNo();
   sourceURL = Lexer::curr()->sourceURL();
@@ -96 +110 @@
 Node::~Node()
 {
+#ifndef NDEBUG
+    --NodeCounter::count;
+#endif
 }
 

trunk/JavaScriptCore/kxmlcore/VectorTraits.h

@@ -79 +79 @@
     struct SimpleClassVectorTraits
     {
-        static const bool needsDestruction = false;
+        static const bool needsDestruction = true;
         static const bool needsInitialization = true;
         static const bool canInitializeWithMemset = true;