Changeset 127930 in webkit for trunk/Source/JavaScriptCore/runtime

Timestamp:

Sep 7, 2012, 3:50:45 PM (13 years ago)

Author:

[email protected]

Message:

Object.prototype.define{G,S}etter with non-callable second parameter should throw TypeError instead of SyntaxError
​https://bugs.webkit.org/show_bug.cgi?id=93873

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):

• throw TypeError instead of SyntaxError

(JSC::objectProtoFuncDefineSetter):

• throw TypeError instead of SyntaxError

LayoutTests:

• fast/js/property-getters-and-setters-expected.txt:
  • updated results

File:

• trunk/Source/JavaScriptCore/runtime/ObjectPrototype.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/ObjectPrototype.cpp

@@ -158 +158 @@
     CallData callData;
     if (getCallData(get, callData) == CallTypeNone)
-        return throwVMError(exec, createSyntaxError(exec, ASCIILiteral("invalid getter usage")));
+        return throwVMError(exec, createTypeError(exec, ASCIILiteral("invalid getter usage")));
 
     PropertyDescriptor descriptor;
@@ -178 +178 @@
     CallData callData;
     if (getCallData(set, callData) == CallTypeNone)
-        return throwVMError(exec, createSyntaxError(exec, ASCIILiteral("invalid setter usage")));
+        return throwVMError(exec, createTypeError(exec, ASCIILiteral("invalid setter usage")));
 
     PropertyDescriptor descriptor;