Changeset 13663 in webkit

Timestamp:

Apr 3, 2006, 4:49:39 PM (19 years ago)

Author:

staikos

Message:

Reviewed by Maciej.

Implement a unicode abstraction layer to make JavaScriptCore much more
easily ported to other platforms without having to take in libicu. Also
makes the unicode related code easier to understand.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/function.cpp (modified) (2 diffs)
• kjs/lexer.cpp (modified) (4 diffs)
• kjs/ustring.cpp (modified) (2 diffs)
• kxmlcore/Platform.h (modified) (1 diff)
• kxmlcore/unicode (added)
• kxmlcore/unicode/Unicode.h (added)
• kxmlcore/unicode/UnicodeCategory.h (added)
• kxmlcore/unicode/icu (added)
• kxmlcore/unicode/icu/UnicodeIcu.h (added)
• kxmlcore/unicode/posix (added)
• kxmlcore/unicode/qt3 (added)
• kxmlcore/unicode/qt4 (added)
• kxmlcore/unicode/qt4/UnicodeQt4.h (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2006-04-03  George Staikos   <[email protected]>
+
+        Reviewed by Maciej.
+
+        Implement a unicode abstraction layer to make JavaScriptCore much more
+        easily ported to other platforms without having to take in libicu.  Also
+        makes the unicode related code easier to understand.
+
 2006-04-03  Timothy Hatcher  <[email protected]>
 

trunk/JavaScriptCore/kjs/function.cpp

@@ -41 +41 @@
 #include <ctype.h>
 
-#include <unicode/uchar.h>
+#include <kxmlcore/unicode/Unicode.h>
 
 namespace KJS {
@@ -662 +662 @@
             return true;
         default:
-            return u_charType(c) == U_SPACE_SEPARATOR;
+            return KXMLCore::Unicode::isSeparatorSpace(c);
     }
 }

trunk/JavaScriptCore/kjs/lexer.cpp

@@ -38 +38 @@
 #include "lookup.h"
 #include "internal.h"
-#include <unicode/uchar.h>
+#include <kxmlcore/unicode/Unicode.h>
 
 static bool isDecimalDigit(unsigned short c);
@@ -138 +138 @@
       }
       next3 = code[pos++].uc;
-    } while (u_charType(next3) == U_FORMAT_CHAR);
+    } while (KXMLCore::Unicode::isFormatChar(next3));
   }
 }
@@ -573 +573 @@
 bool Lexer::isWhiteSpace() const
 {
-  return (current == '\t' || current == 0x0b || current == 0x0c || u_charType(current) == U_SPACE_SEPARATOR);
+  return current == '\t' || current == 0x0b || current == 0x0c || KXMLCore::Unicode::isSeparatorSpace(current);
 }
 
@@ -589 +589 @@
 bool Lexer::isIdentStart(unsigned short c)
 {
-  return (U_GET_GC_MASK(c) & (U_GC_L_MASK | U_GC_NL_MASK)) || c == '$' || c == '_';
+  return (KXMLCore::Unicode::category(c) & (KXMLCore::Unicode::Letter_Uppercase
+        | KXMLCore::Unicode::Letter_Lowercase
+        | KXMLCore::Unicode::Letter_Titlecase
+        | KXMLCore::Unicode::Letter_Modifier
+        | KXMLCore::Unicode::Letter_Other))
+    || c == '$' || c == '_';
 }
 
 bool Lexer::isIdentPart(unsigned short c)
 {
-  return (U_GET_GC_MASK(c) & (U_GC_L_MASK | U_GC_NL_MASK | U_GC_MN_MASK | U_GC_MC_MASK | U_GC_ND_MASK | U_GC_PC_MASK)) || c == '$' || c == '_';
+  return (KXMLCore::Unicode::category(c) & (KXMLCore::Unicode::Letter_Uppercase
+        | KXMLCore::Unicode::Letter_Lowercase
+        | KXMLCore::Unicode::Letter_Titlecase
+        | KXMLCore::Unicode::Letter_Modifier
+        | KXMLCore::Unicode::Letter_Other
+        | KXMLCore::Unicode::Mark_NonSpacing
+        | KXMLCore::Unicode::Mark_SpacingCombining
+        | KXMLCore::Unicode::Number_DecimalDigit
+        | KXMLCore::Unicode::Punctuation_Connector))
+    || c == '$' || c == '_';
 }
 

trunk/JavaScriptCore/kjs/ustring.cpp

@@ -45 +45 @@
 using std::max;
 
-#include <unicode/uchar.h>
+#include <kxmlcore/unicode/Unicode.h>
 
 namespace KJS {
@@ -145 +145 @@
 UChar UChar::toLower() const
 {
-  return static_cast<unsigned short>(u_tolower(uc));
+  return KXMLCore::Unicode::toLower(uc);
 }
 
 UChar UChar::toUpper() const
 {
-  return static_cast<unsigned short>(u_toupper(uc));
+  return KXMLCore::Unicode::toUpper(uc);
 }
 

trunk/JavaScriptCore/kxmlcore/Platform.h

@@ -150 +150 @@
 #if PLATFORM(MAC)
 #define KXMLCORE_USE_MULTIPLE_THREADS 1
+#define KXMLCORE_USE_ICU_UNICODE 1
+#endif
+
+#if PLATFORM(KDE)
+#define KXMLCORE_USE_QT4_UNICODE 1
 #endif