Changeset 15155 in webkit for trunk/JavaScriptCore/wtf

Timestamp:

Jul 4, 2006, 9:13:32 PM (19 years ago)

Author:

darin

Message:

Reviewed by Maciej.
Tweaked a bit by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 work around MSVCRT's fmod function returning NaN for fmod(x, infinity) instead of x

• wtf/MathExtras.h: Added include of <float.h>. (isinf): Fix to return false for NAN. (wtf_fmod): Added. An inline that works around the bug.

• kjs/nodes.cpp:
• kjs/number_object.cpp:
• kjs/operations.cpp:
• kjs/value.cpp: Added includes of MathExtras.h to all files using fmod.

• JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode 2.3 have its way with the project.

File:

• trunk/JavaScriptCore/wtf/MathExtras.h (modified) (2 diffs)

trunk/JavaScriptCore/wtf/MathExtras.h

@@ -30 +30 @@
 #include <xmath.h>
 
-inline bool isinf(double num) { return !_finite(num); }
+#if HAVE(FLOAT_H)
+#include <float.h>
+#endif
+
+inline bool isinf(double num) { return !_finite(num) && !_isnan(num); }
 inline bool isnan(double num) { return _isnan(num); }
 inline long lround(double num) { return num > 0 ? num + 0.5 : ceil(num - 0.5); }
@@ -38 +42 @@
 inline bool signbit(double num) { return _copysign(1.0, num) < 0; }
 
+#if PLATFORM(WIN) && COMPILER(MSVC)
+
+// Work around a bug in the Microsoft CRT, where fmod(x, +-infinity) yields NaN instead of x.
+inline double wtf_fmod(double x, double y) { return (!isinf(x) && isinf(y)) ? x : fmod(x, y); }
+
+#define fmod(x, y) wtf_fmod(x, y)
+
 #endif