Changeset 153071 in webkit for trunk/Source/JavaScriptCore/bytecompiler

Timestamp:

Jul 23, 2013, 5:41:46 PM (12 years ago)

Author:

[email protected]

Message:

Removed unused sourceOffset from JSTokenLocation.
​https://bugs.webkit.org/show_bug.cgi?id=118996.

Reviewed by Geoffrey Garen.

This also removes the assertion reported in the bug because it is now
moot, thereby resolving the assertion failure issue on Windows.

• bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

• parser/Lexer.cpp:

(JSC::::lex):

• parser/Lexer.h:

(JSC::::lexExpectIdentifier):

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseFunctionInfo):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseMemberExpression):

• parser/Parser.h:

(JSC::::parse):

• parser/ParserTokens.h:

(JSC::JSTokenLocation::JSTokenLocation):

File:

• trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

@@ -203 +203 @@
 }
 
-ArgumentListNode* ArrayNode::toArgumentList(VM* vm, int lineNumber, int startPosition, unsigned sourceOffset) const
+ArgumentListNode* ArrayNode::toArgumentList(VM* vm, int lineNumber, int startPosition) const
 {
     ASSERT(!m_elision && !m_optional);
@@ -209 +209 @@
     if (!ptr)
         return 0;
-    JSTokenLocation location(sourceOffset);
+    JSTokenLocation location;
     location.line = lineNumber;
     location.startOffset = startPosition;
-    location.sourceOffset = sourceOffset;
     ArgumentListNode* head = new (vm) ArgumentListNode(location, ptr->value());
     ArgumentListNode* tail = head;
@@ -550 +549 @@
                     ASSERT(m_args->m_listNode->m_next->m_expr->isSimpleArray());
                     ASSERT(!m_args->m_listNode->m_next->m_next);
-                    m_args->m_listNode = static_cast<ArrayNode*>(m_args->m_listNode->m_next->m_expr)->toArgumentList(generator.vm(), 0, 0, 0);
+                    m_args->m_listNode = static_cast<ArrayNode*>(m_args->m_listNode->m_next->m_expr)->toArgumentList(generator.vm(), 0, 0);
                     RefPtr<RegisterID> realFunction = generator.emitMove(generator.tempDestination(dst), base.get());
                     CallArguments callArguments(generator, m_args);