Changeset 15473 in webkit for trunk/JavaScriptCore/API/minidom.js

Timestamp:

Jul 16, 2006, 6:48:27 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Properly document and handle NULL callbacks for static properties. We throw an exception in any case other than a ReadOnly property with a NULL setProperty callback, because a NULL callback almost certainly indicates a programming error. Also throw an exception if hasProperty returns true for a property that getProperty can't get.

• If a static setProperty callback returns 'false', to indicate that the property was not set, we no longer forward the set request up the class chain, because that's almost certainly not what the programmer expected.

• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter): (KJS::JSCallbackObject::callbackGetter):
• API/JSObjectRef.h:
• API/minidom.js:
• API/testapi.c: (MyObject_hasProperty):
• API/testapi.js:

File:

• trunk/JavaScriptCore/API/minidom.js (modified) (2 diffs)

trunk/JavaScriptCore/API/minidom.js

@@ -166 +166 @@
 }
 
+function shouldBe(a, b)
+{
+    var evalA;
+    try {
+        evalA = eval(a);
+    } catch(e) {
+        evalA = e;
+    }
+    
+    if (evalA == b || isNaN(evalA) && typeof evalA == 'number' && isNaN(b) && typeof b == 'number')
+        print("PASS: " + a + " should be " + b + " and is.", "green");
+    else
+        print("__FAIL__: " + a + " should be " + b + " but instead is " + evalA + ".", "red");
+}
+
 function test()
 {
@@ -222 +237 @@
         print("caught: " + e);
     }
+    
+    oldNodeType = node.nodeType;
+    node.nodeType = 1;
+    shouldBe("node.nodeType", oldNodeType);
 
     /*