Changeset 15473 in webkit for trunk/JavaScriptCore/API/testapi.js

Timestamp:

Jul 16, 2006, 6:48:27 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Properly document and handle NULL callbacks for static properties. We throw an exception in any case other than a ReadOnly property with a NULL setProperty callback, because a NULL callback almost certainly indicates a programming error. Also throw an exception if hasProperty returns true for a property that getProperty can't get.

• If a static setProperty callback returns 'false', to indicate that the property was not set, we no longer forward the set request up the class chain, because that's almost certainly not what the programmer expected.

• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter): (KJS::JSCallbackObject::callbackGetter):
• API/JSObjectRef.h:
• API/minidom.js:
• API/testapi.c: (MyObject_hasProperty):
• API/testapi.js:

File:

• trunk/JavaScriptCore/API/testapi.js (modified) (3 diffs)

trunk/JavaScriptCore/API/testapi.js

@@ -40 +40 @@
 }
 
+function shouldThrow(a)
+{
+    var result = "__FAIL__: " + a + " did not throw an exception.";
+    
+    var evalA;
+    try {
+        eval(a);
+    } catch(e) {
+        result = "PASS: " + a + " threw: " + e;
+    }
+    
+    print(result);
+}
+
 shouldBe("typeof MyObject", "function"); // our object implements 'call'
 MyObject.cantFind = 1;
@@ -69 +83 @@
       : "__FAIL__: MyObject.regularType was not enumerated");
 
+myObject = new MyObject();
+
 shouldBe("delete MyObject.regularType", true);
 shouldBe("MyObject.regularType", undefined);
 shouldBe("MyObject(0)", 1);
 shouldBe("MyObject()", undefined);
-shouldBe("typeof new MyObject()", "object");
+shouldBe("typeof myObject", "object");
 shouldBe("MyObject ? 1 : 0", true); // toBoolean
 shouldBe("+MyObject", 1); // toNumber
@@ -83 +99 @@
 shouldBe("typeof constructedObject", "object");
 shouldBe("constructedObject.value", 1);
-shouldBe("(new MyObject()) instanceof MyObject", true);
+shouldBe("myObject instanceof MyObject", true);
 shouldBe("(new Object()) instanceof MyObject", false);
+
+shouldThrow("MyObject.nullGetSet = 1");
+shouldThrow("MyObject.nullGetSet");
+shouldThrow("MyObject.nullCall()");
+shouldThrow("MyObject.hasPropertyLie");