Changeset 15557 in webkit for trunk/JavaScriptCore

Timestamp:

Jul 21, 2006, 11:50:24 AM (19 years ago)

Author:

ggaren

Message:

JavaScriptCore:

Reviewed by Darin.

• Added support for strings that masquerade as undefined. Currently used by WebCore to implement undetectable style.filter.

The name is a little long, but it's only used in one line of code, so I
thought clarity should win over brevity.

• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/object.h:
• kjs/string_object.h: (KJS::StringInstanceThatMasqueradesAsUndefined::StringInstanceThatMasqueradesAsUndefined): (KJS::StringInstanceThatMasqueradesAsUndefined::masqueradeAsUndefined): (KJS::StringInstanceThatMasqueradesAsUndefined::toBoolean):

LayoutTests:

Test for undetectable style.filter property.

• fast/dom/undetectable-style-filter-expected.txt: Added.
• fast/dom/undetectable-style-filter.html: Added.

WebCore:

Reviewed by Darin.

• Fixed <rdar://problem/4507265> REGRESSION: overlays don't work on HousingMaps.com (Google Maps-based site)

• Made style.filter undetectable, like document.all.

Unfortunately, the SVG spec-makers invented a CSS attribute named 'filter',
which conflicts with IE's custom CSS attribute by the same name. Web programs
like the Google maps API test for style.filter, and assume it's the IE
style.filter if they find it, so we need to make style.filter undetectable
to avoid breaking them.

An alternative solution would be to hotwire a delorean, go back in time,
and beg the web standards makers to make standards that work on the web.

• bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• JavaScriptCore.exp (modified) (4 diffs)
• kjs/object.h (modified) (1 diff)
• kjs/string_object.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2006-07-21  Geoffrey Garen  <[email protected]>
+
+        Reviewed by Darin.
+
+        - Added support for strings that masquerade as undefined. Currently used
+        by WebCore to implement undetectable style.filter.
+        
+        The name is a little long, but it's only used in one line of code, so I
+        thought clarity should win over brevity.
+
+        * JavaScriptCore.exp:
+        * JavaScriptCore.xcodeproj/project.pbxproj:
+        * kjs/object.h:
+        * kjs/string_object.h:
+        (KJS::StringInstanceThatMasqueradesAsUndefined::StringInstanceThatMasqueradesAsUndefined):
+        (KJS::StringInstanceThatMasqueradesAsUndefined::masqueradeAsUndefined):
+        (KJS::StringInstanceThatMasqueradesAsUndefined::toBoolean):
+
 2006-07-20  Steve Falkenburg  <[email protected]>
 

trunk/JavaScriptCore/JavaScriptCore.exp

@@ +1 @@
+
 _JSCheckScriptSyntax
 _JSClassCreate
@@ -144 +145 @@
 __ZN3KJS13SavedBuiltinsC1Ev
 __ZN3KJS13SavedBuiltinsD1Ev
+__ZN3KJS14StringInstance14deletePropertyEPNS_9ExecStateERKNS_10IdentifierE
+__ZN3KJS14StringInstance16getPropertyNamesEPNS_9ExecStateERNS_17PropertyNameArrayE
+__ZN3KJS14StringInstance18getOwnPropertySlotEPNS_9ExecStateERKNS_10IdentifierERNS_12PropertySlotE
+__ZN3KJS14StringInstance3putEPNS_9ExecStateERKNS_10IdentifierEPNS_7JSValueEi
+__ZN3KJS14StringInstance4infoE
+__ZN3KJS14StringInstanceC1EPNS_8JSObjectERKNS_7UStringE
+__ZN3KJS14StringInstanceC2EPNS_8JSObjectERKNS_7UStringE
 __ZN3KJS15SavedPropertiesC1Ev
 __ZN3KJS15SavedPropertiesD1Ev
@@ -223 +231 @@
 __ZNK3KJS11Interpreter15builtinFunctionEv
 __ZNK3KJS11Interpreter22builtinObjectPrototypeEv
+__ZNK3KJS11Interpreter22builtinStringPrototypeEv
 __ZNK3KJS11Interpreter24builtinFunctionPrototypeEv
 __ZNK3KJS11PropertyMap3getERKNS_10IdentifierE
@@ -260 +269 @@
 __ZNK3KJS8JSObject9toBooleanEPNS_9ExecStateE
 __ZNK3KJS9ExecState18lexicalInterpreterEv
+__ZTVN3KJS14StringInstanceE
 __ZTVN3KJS19InternalFunctionImpE
 __ZTVN3KJS8JSObjectE

trunk/JavaScriptCore/kjs/object.h

@@ -471 +471 @@
     bool getPropertyAttributes(const Identifier& propertyName, unsigned& attributes) const;
     
-    // Returns whether the object should be treated as undefined when doing equality comparisons
+    // WebCore uses this to make document.all and style.filter undetectable
     virtual bool masqueradeAsUndefined() const { return false; }
     

trunk/JavaScriptCore/kjs/string_object.h

@@ -42 +42 @@
     static JSValue *lengthGetter(ExecState *exec, JSObject *, const Identifier&, const PropertySlot &slot);
     static JSValue *indexGetter(ExecState *exec, JSObject *, const Identifier&, const PropertySlot &slot);
+  };
+
+  // WebCore uses this to make style.filter undetectable
+  class StringInstanceThatMasqueradesAsUndefined : public StringInstance {
+  public:
+      StringInstanceThatMasqueradesAsUndefined(JSObject* proto, const UString& string)
+          : StringInstance(proto, string) { }
+      virtual bool masqueradeAsUndefined() const { return true; }
+      virtual bool toBoolean(ExecState*) const { return false; }
   };