Changeset 15799 in webkit for trunk/JavaScriptCore/API

Timestamp:

Aug 4, 2006, 11:57:40 AM (19 years ago)

Author:

weinig

Message:

JavaScriptCore:

Reviewed by Darin.

• patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

• Adds -Wshorten-64-to-32 flag to Xcode project.
• Adds explicit casts where OK.

• API/JSNodeList.c: (JSNodeList_item): (JSNodeList_getProperty):
• JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by Darin.

• patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

• Adds -Wshorten-64-to-32 flag to Xcode project.

• JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

• patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

• Adds -Wshorten-64-to-32 flag to Xcode project.
• Adds 'f' to float literals where expecting a float.
• Use cosf() instead of cos() when assigning to a float.

• WebCore.xcodeproj/project.pbxproj:
• kcanvas/device/quartz/filters/WKDiffuseLightingFilter.m: (+[WKDiffuseLightingFilter initialize]):
• kcanvas/device/quartz/filters/WKDiscreteTransferFilter.m: (-[WKDiscreteTransferFilter outputImage]):
• kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: (+[WKDisplacementMapFilter initialize]):
• kcanvas/device/quartz/filters/WKSpecularLightingFilter.m: (+[WKSpecularLightingFilter initialize]):
• kcanvas/device/quartz/filters/WKSpotLightFilter.m: (-[WKSpotLightFilter outputImage]):
• kcanvas/device/quartz/filters/WKTableTransferFilter.m: (-[WKTableTransferFilter outputImage]):

WebKit:

Reviewed by Darin.

• patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10192 Make WebCore (and friends) compile with -Wshorten-64-to-32

• Adds 'f' to float literals where expecting a float.
• Use ceilf() instead of ceil() when assigning to a float.
• Adds explicit casts where OK.

NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
because there are still a few places where no error handling
is in place. The flag can be added as soon as those are worked
out.

• Misc/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]):
• Misc/WebNSImageExtras.m: (-[NSImage _web_scaleToMaxSize:]):
• Misc/WebNSViewExtras.h:
• Misc/WebNSViewExtras.m:
• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView drawRect:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge expiresTimeForResponse:]):
• WebInspector/WebInspector.m: (-[NSWindow window]): (-treeViewScrollTo:): (-_updateSystemColors): (-webView:plugInViewWithArguments:): (-outlineView:objectValueForTableColumn:byItem:):
• WebInspector/WebInspectorOutlineView.m: (-[WebInspectorOutlineView _highlightRow:clipRect:]):
• WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight initWithBounds:andRects:forView:]):
• WebInspector/WebNodeHighlightView.m: (-[WebNodeHighlightView roundedRect:withRadius:]): (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): (-[WebNodeHighlightView drawRect:]):
• WebView/WebFrame.m: (-[WebFrame _opened]):
• WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
• WebView/WebHTMLView.m: (-[WebHTMLView _dragImageForLinkElement:]): (-[WebHTMLView _web_setPrintingModeRecursive]): (-[WebHTMLView _web_clearPrintingModeRecursive]): (-[NSArray layout]): (-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]): (-[NSArray adjustPageHeightNew:top:bottom:limit:]): (-[NSArray _scaleFactorForPrintOperation:]): (-[NSArray setPageWidthForPrinting:]): (-[NSArray _endPrintMode]): (-[NSArray knowsPageRange:]): (-[NSArray _originalFontA]): (-[NSArray _originalFontB]): (-[WebTextCompleteController _buildUI]): (-[WebTextCompleteController _placePopupWindow:]):
• WebView/WebPDFView.m: (-[WebPDFView _makeTextStandardSize:]): (-[WebPDFView selectionImageForcingWhiteText:]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
• WebView/WebPreferences.m: (-[WebPreferences _floatValueForKey:]):
• WebView/WebView.m: (-[WebView makeTextSmaller:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]):

File:

• trunk/JavaScriptCore/API/JSNodeList.c (modified) (2 diffs)

trunk/JavaScriptCore/API/JSNodeList.c

@@ -34 +34 @@
         NodeList* nodeList = JSObjectGetPrivate(thisObject);
         assert(nodeList);
-        Node* node = NodeList_item(nodeList, JSValueToNumber(context, arguments[0], exception));
+        Node* node = NodeList_item(nodeList, (unsigned)JSValueToNumber(context, arguments[0], exception));
         if (node)
             return JSNode_new(context, node);
@@ -66 +66 @@
     assert(nodeList);
     double index = JSValueToNumber(context, JSValueMakeString(context, propertyName), exception);
-    unsigned uindex = index;
+    unsigned uindex = (unsigned)index;
     if (uindex == index) { // false for NaN
         Node* node = NodeList_item(nodeList, uindex);
-        if (node) {
+        if (node)
             return JSNode_new(context, node);
-        }
     }