Changeset 161866 in webkit for trunk/Source/JavaScriptCore

Timestamp:

Jan 13, 2014, 1:23:12 AM (11 years ago)

Author:

[email protected]

Message:

Unreviewed. Changes in r161686 are exposing a bug in GCC where the global .cfi_startproc directive
is not inserted early enough into the generated assembler code when building in debug mode, causing
compilation failures on ports using the GCC compilers. To work around the problem, only utilize the
OFFLINE_ASM_* macros that use .cfi_ directives when compiling with Clang.

• llint/LowLevelInterpreter.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• llint/LowLevelInterpreter.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-01-13  Zan Dobersek  <[email protected]>
+
+        Unreviewed. Changes in r161686 are exposing a bug in GCC where the global .cfi_startproc directive
+        is not inserted early enough into the generated assembler code when building in debug mode, causing
+        compilation failures on ports using the GCC compilers. To work around the problem, only utilize the
+        OFFLINE_ASM_* macros that use .cfi_ directives when compiling with Clang.
+
+        * llint/LowLevelInterpreter.cpp:
+
 2014-01-12  Commit Queue  <[email protected]>
 

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp

@@ -523 +523 @@
 
 // These are for building an interpreter from generated assembly code:
-#if CPU(X86_64)
+#if CPU(X86_64) && COMPILER(CLANG)
 #define OFFLINE_ASM_BEGIN   asm ( \
     ".cfi_startproc\n"
@@ -546 +546 @@
     ".thumb_func " THUMB_FUNC_PARAM(label) "\n"  \
     SYMBOL_STRING(label) ":\n"
-#elif CPU(X86_64)
+#elif CPU(X86_64) && COMPILER(CLANG)
 #define OFFLINE_ASM_GLOBAL_LABEL(label)         \
     ".text\n"                                   \