Changeset 163254 in webkit for trunk/Source/JavaScriptCore/profiler

Timestamp:

Feb 1, 2014, 6:25:13 PM (11 years ago)

Author:

[email protected]

Message:

JSC profiler should show reasons for jettison
​https://bugs.webkit.org/show_bug.cgi?id=128047

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Henceforth if you want to jettison a CodeBlock, you gotta tell the Profiler why you did
it. This makes figuring out convergence issues - where some code seems to take a long
time to get into the top tier compiler - a lot easier.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::addBreakpoint):
(JSC::CodeBlock::setSteppingMode):

• bytecode/CodeBlock.h:
• bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

• bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

• dfg/DFGOperations.cpp:
• jit/JITOperations.cpp:
• profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::Compilation):
(JSC::Profiler::Compilation::toJS):

• profiler/ProfilerCompilation.h:

(JSC::Profiler::Compilation::setJettisonReason):

• profiler/ProfilerJettisonReason.cpp: Added.

(WTF::printInternal):

• profiler/ProfilerJettisonReason.h: Added.
• runtime/CommonIdentifiers.h:
• runtime/VM.cpp:

(JSC::SetEnabledProfilerFunctor::operator()):

Tools:

Reviewed by Geoffrey Garen.

Gave the tool a "log" command, that tells you all of the interesting things
that happened to a piece of bytecode, from the standpoint of optimization.
It's a great summary view for seeing how our tier-up machinery works.

This uses a lot of information that was already available, plus the newly
added jettisonReason field.

• Scripts/display-profiler-output:

Location:

trunk/Source/JavaScriptCore/profiler

Files:

• ProfilerCompilation.cpp (modified) (2 diffs)
• ProfilerCompilation.h (modified) (3 diffs)
• ProfilerJettisonReason.cpp (added)
• ProfilerJettisonReason.h (added)

trunk/Source/JavaScriptCore/profiler/ProfilerCompilation.cpp

@@ -38 +38 @@
     : m_bytecodes(bytecodes)
     , m_kind(kind)
+    , m_jettisonReason(NotJettisoned)
     , m_numInlinedGetByIds(0)
     , m_numInlinedPutByIds(0)
@@ -132 +133 @@
     result->putDirect(exec->vm(), exec->propertyNames().numInlinedPutByIds, jsNumber(m_numInlinedPutByIds));
     result->putDirect(exec->vm(), exec->propertyNames().numInlinedCalls, jsNumber(m_numInlinedCalls));
+    result->putDirect(exec->vm(), exec->propertyNames().jettisonReason, jsString(exec, String::fromUTF8(toCString(m_jettisonReason))));
     
     return result;

trunk/Source/JavaScriptCore/profiler/ProfilerCompilation.h

@@ -32 +32 @@
 #include "ProfilerCompiledBytecode.h"
 #include "ProfilerExecutionCounter.h"
+#include "ProfilerJettisonReason.h"
 #include "ProfilerOSRExit.h"
 #include "ProfilerOSRExitSite.h"
@@ -69 +70 @@
     OSRExit* addOSRExit(unsigned id, const OriginStack&, ExitKind, bool isWatchpoint);
     
+    void setJettisonReason(JettisonReason jettisonReason)
+    {
+        m_jettisonReason = jettisonReason;
+    }
+    
     JSValue toJS(ExecState*) const;
     
@@ -74 +80 @@
     Bytecodes* m_bytecodes;
     CompilationKind m_kind;
+    JettisonReason m_jettisonReason;
     Vector<ProfiledBytecodes> m_profiledBytecodes;
     Vector<CompiledBytecode> m_descriptions;