Changeset 17091 in webkit for trunk/JavaScriptCore/wtf

Timestamp:

Oct 17, 2006, 2:46:36 PM (19 years ago)

Author:

kmccullo

Message:

Reviewed by Brady.

Fixes a JavaScriptCore math issue on win.

• kjs/math_object.cpp: (MathFuncImp::callAsFunction):
• wtf/MathExtras.h: (wtf_atan2):

File:

• trunk/JavaScriptCore/wtf/MathExtras.h (modified) (3 diffs)

trunk/JavaScriptCore/wtf/MathExtras.h

@@ -24 +24 @@
  */
 
+#ifndef MATH_EXTRAS_H_
+#define MATH_EXTRAS_H_
+
 #include <math.h>
 
 #if PLATFORM(WIN)
 
+#include "kjs/operations.h"
+#include "kjs/value.h"
 #include <xmath.h>
+#include <limits>
 
 #if HAVE(FLOAT_H)
@@ -48 +54 @@
 inline int isfinite(double x) { return _finite(x); }
 
+#ifndef M_PI
+#define M_PI 3.14159265358979323846
+#endif  //  M_PI
+
+#ifndef M_PI_4
+#define M_PI_4 0.785398163397448309616
+#endif  //  M_PI_4
+
+// Work around a bug in Win, where atan2(+-infinity, +-infinity) yields NaN instead of specific values.
+inline double wtf_atan2(double x, double y)
+{
+    static double posInf = std::numeric_limits<double>::infinity();
+    static double negInf = -std::numeric_limits<double>::infinity();
+
+    double result = KJS::NaN;
+
+    if (x == posInf && y == posInf)
+        result = M_PI_4;
+    else if (x == posInf && y == negInf)
+        result = 3 * M_PI_4;
+    else if (x == negInf && y == posInf)
+        result = -M_PI_4;
+    else if (x == negInf && y == negInf)
+        result = -3 * M_PI_4;
+    else
+        result = ::atan2(x, y);
+
+    return result;
+}
+
 #if COMPILER(MSVC)
 
@@ -55 +91 @@
 #define fmod(x, y) wtf_fmod(x, y)
 
-#endif
+#endif // #if COMPILER(MSVC)
 
-#endif
+#define atan2(x, y) wtf_atan2(x, y)
+
+#endif // #if PLATFORM(WIN)
+
+#endif // #ifndef MATH_EXTRAS_H_