Changeset 173141 in webkit for trunk/Source/JavaScriptCore/API

Timestamp:

Aug 30, 2014, 3:43:33 PM (11 years ago)

Author:

[email protected]

Message:

Use RetainPtr::autorelease in some places where it seems appropriate
​https://bugs.webkit.org/show_bug.cgi?id=136280

Reviewed by Darin Adler.

Source/JavaScriptCore:

• API/JSContext.mm:

(-[JSContext name]): Use RetainPtr::autorelease() in place of ObjC autorelease.

• API/JSValue.mm:

(valueToString): Make appropriate use of RetainPtr

Source/WebCore:

• platform/mac/URLMac.mm:

(WebCore::URL::operator NSURL *): Use autorelease() instead of
CFBridgingRelease(leakRef())

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

(imageFromRect): Use RetainPtr in this function.

• WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use RetainPtr
in this method.

Source/WebKit2:

• Shared/Cocoa/WKNSURLExtras.mm:

(urlWithWTFString): Use autorelease() instead of CFBridgingRelease(leakRef())

Source/WTF:

• wtf/text/mac/StringImplMac.mm:

(WTF::StringImpl::operator NSString *): Use autorelease() instead of
CFBridgingRelease(leakRef())

Location:

trunk/Source/JavaScriptCore/API

Files:

• JSContext.mm (modified) (1 diff)
• JSValue.mm (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSContext.mm

@@ -193 +193 @@
         return nil;
 
-    return [(NSString *)JSStringCopyCFString(kCFAllocatorDefault, name) autorelease];
+    return (NSString *)adoptCF(JSStringCopyCFString(kCFAllocatorDefault, name)).autorelease();
 }
 

trunk/Source/JavaScriptCore/API/JSValue.mm

@@ -768 +768 @@
     }
 
-    NSString *stringNS = CFBridgingRelease(JSStringCopyCFString(kCFAllocatorDefault, jsstring));
+    RetainPtr<CFStringRef> stringCF = adoptCF(JSStringCopyCFString(kCFAllocatorDefault, jsstring));
     JSStringRelease(jsstring);
-    return stringNS;
+    return (NSString *)stringCF.autorelease();
 }