Changeset 17372 in webkit for trunk/JavaScriptCore/API

Timestamp:

Oct 27, 2006, 9:48:28 AM (19 years ago)

Author:

darin

Message:

Reviewed by Geoff.

• made changes so the code compiles with the highest warning level under MSVC (disabling some warnings, making some code fixes)

• API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
• API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
• API/JSObjectRef.cpp: (JSPropertyNameArrayGetNameAtIndex):
• API/JSStringRef.cpp: (JSStringCreateWithCharacters):
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): (KJS::Bindings::coerceValueToNPVariantStringType): (KJS::Bindings::convertValueToNPVariant):
• kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime):
• kjs/ExecState.h: (KJS::ExecState::hadException):
• kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits):
• kjs/Parser.h:
• kjs/PropertyNameArray.h: (KJS::PropertyNameArray::size):
• kjs/array_object.cpp: (ArrayObjectImp::callAsFunction):
• kjs/bool_object.cpp: (BooleanObjectImp::callAsFunction):
• kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::collect):
• kjs/completion.h: (KJS::Completion::isValueCompletion):
• kjs/date_object.cpp: (KJS::findMonth):
• kjs/debugger.cpp: (Debugger::sourceParsed): (Debugger::sourceUnused): (Debugger::exception): (Debugger::atStatement): (Debugger::callEvent): (Debugger::returnEvent):
• kjs/dtoa.cpp:
• kjs/error_object.cpp: (ErrorObjectImp::callAsFunction): (NativeErrorImp::callAsFunction):
• kjs/function.cpp: (KJS::FunctionImp::processVarDecls): (KJS::GlobalFuncImp::callAsFunction):
• kjs/function_object.cpp: (FunctionPrototype::callAsFunction):
• kjs/grammar.y:
• kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::Identifier::add):
• kjs/internal.h:
• kjs/lexer.cpp: (Lexer::lex): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::isHexDigit): (Lexer::isOctalDigit): (Lexer::matchPunctuator): (Lexer::singleEscape): (Lexer::convertOctal): (Lexer::convertHex): (Lexer::convertUnicode): (Lexer::record8):
• kjs/lexer.h:
• kjs/math_object.cpp: (MathFuncImp::callAsFunction):
• kjs/number_object.cpp: (integer_part_noexp): (intPow10): (NumberProtoFunc::callAsFunction): (NumberObjectImp::callAsFunction):
• kjs/object.cpp: (KJS::JSObject::deleteProperty): (KJS::JSObject::callAsFunction): (KJS::JSObject::toBoolean): (KJS::JSObject::toObject):
• kjs/object.h: (KJS::JSObject::getPropertySlot):
• kjs/property_map.cpp: (KJS::isValid): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::containsGettersOrSetters):
• kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties):
• kjs/property_slot.h:
• kjs/string_object.cpp: (StringInstance::getPropertyNames): (StringObjectImp::callAsFunction): (StringObjectFuncImp::callAsFunction):
• kjs/ustring.cpp: (KJS::UString::Rep::computeHash): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::operator=): (KJS::UString::find): (KJS::UString::rfind):
• kjs/ustring.h: (KJS::UChar::high): (KJS::UChar::low): (KJS::UCharReference::low): (KJS::UCharReference::high):
• kjs/value.cpp: (KJS::JSValue::toUInt16):
• kjs/value.h:
• pcre/pcre_compile.c: (get_othercase_range):
• pcre/pcre_exec.c: (match):
• pcre/pcre_internal.h:
• wtf/HashFunctions.h: (WTF::intHash): (WTF::PtrHash::hash):
• wtf/MathExtras.h: (isnan): (lround): (lroundf):
• wtf/StringExtras.h: (strncasecmp):
• wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar):

Location:

trunk/JavaScriptCore/API

Files:

• JSCallbackConstructor.cpp (modified) (1 diff)
• JSCallbackFunction.cpp (modified) (1 diff)
• JSCallbackObject.cpp (modified) (3 diffs)
• JSObjectRef.cpp (modified) (1 diff)
• JSStringRef.cpp (modified) (1 diff)

trunk/JavaScriptCore/API/JSCallbackConstructor.cpp

@@ -66 +66 @@
 
     if (m_callback) {
-        size_t argumentCount = args.size();
+        int argumentCount = static_cast<int>(args.size());
         Vector<JSValueRef, 16> arguments(argumentCount);
-        for (size_t i = 0; i < argumentCount; i++)
+        for (int i = 0; i < argumentCount; i++)
             arguments[i] = toRef(args[i]);
         return toJS(m_callback(ctx, thisRef, argumentCount, arguments, toRef(exec->exceptionSlot())));

trunk/JavaScriptCore/API/JSCallbackFunction.cpp

@@ -55 +55 @@
     JSObjectRef thisObjRef = toRef(thisObj);
 
-    size_t argumentCount = args.size();
+    int argumentCount = static_cast<int>(args.size());
     Vector<JSValueRef, 16> arguments(argumentCount);
-    for (size_t i = 0; i < argumentCount; i++)
+    for (int i = 0; i < argumentCount; i++)
         arguments[i] = toRef(args[i]);
     return toJS(m_callback(execRef, thisRef, thisObjRef, argumentCount, arguments, toRef(exec->exceptionSlot())));

trunk/JavaScriptCore/API/JSCallbackObject.cpp

@@ -59 +59 @@
     
     // initialize from base to derived
-    for (int i = initRoutines.size() - 1; i >= 0; i--) {
+    for (int i = static_cast<int>(initRoutines.size()) - 1; i >= 0; i--) {
         JSObjectInitializeCallback initialize = initRoutines[i];
         initialize(toRef(exec), toRef(this));
@@ -226 +226 @@
     for (JSClassRef jsClass = m_class; jsClass; jsClass = jsClass->parentClass) {
         if (JSObjectCallAsConstructorCallback callAsConstructor = jsClass->callAsConstructor) {
-            size_t argumentCount = args.size();
+            int argumentCount = static_cast<int>(args.size());
             Vector<JSValueRef, 16> arguments(argumentCount);
-            for (size_t i = 0; i < argumentCount; i++)
+            for (int i = 0; i < argumentCount; i++)
                 arguments[i] = toRef(args[i]);
             return toJS(callAsConstructor(execRef, thisRef, argumentCount, arguments, toRef(exec->exceptionSlot())));
@@ -278 +278 @@
     for (JSClassRef jsClass = m_class; jsClass; jsClass = jsClass->parentClass) {
         if (JSObjectCallAsFunctionCallback callAsFunction = jsClass->callAsFunction) {
-            size_t argumentCount = args.size();
+            int argumentCount = static_cast<int>(args.size());
             Vector<JSValueRef, 16> arguments(argumentCount);
-            for (size_t i = 0; i < argumentCount; i++)
+            for (int i = 0; i < argumentCount; i++)
                 arguments[i] = toRef(args[i]);
             return toJS(callAsFunction(execRef, thisRef, thisObjRef, argumentCount, arguments, toRef(exec->exceptionSlot())));

trunk/JavaScriptCore/API/JSObjectRef.cpp

@@ -349 +349 @@
 JSStringRef JSPropertyNameArrayGetNameAtIndex(JSPropertyNameArrayRef array, size_t index)
 {
-    return toRef(array->array[index].ustring().rep());
+    return toRef(array->array[static_cast<unsigned>(index)].ustring().rep());
 }
 

trunk/JavaScriptCore/API/JSStringRef.cpp

@@ -41 +41 @@
 {
     JSLock lock;
-    return toRef(UString(reinterpret_cast<const UChar*>(chars), numChars).rep()->ref());
+    return toRef(UString(reinterpret_cast<const UChar*>(chars), static_cast<int>(numChars)).rep()->ref());
 }