Changeset 174294 in webkit for trunk/Source/JavaScriptCore/llint

Timestamp:

Oct 3, 2014, 2:46:14 PM (11 years ago)

Author:

[email protected]

Message:

tearoff_arguments should always refer to the unmodified arguments register
​https://bugs.webkit.org/show_bug.cgi?id=137406

Reviewed by Michael Saboff.

To simplify subsequent work, and remove unnecessary work from
actual execution this patch simply ensures that tear_off_arguments
refers to the actual unmodified arguments register.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitReturn):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_arguments):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_tear_off_arguments):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

Location:

trunk/Source/JavaScriptCore/llint

Files:

• LLIntSlowPaths.cpp (modified) (1 diff)
• LowLevelInterpreter32_64.asm (modified) (1 diff)
• LowLevelInterpreter64.asm (modified) (1 diff)

trunk/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp

@@ -1250 +1250 @@
     LLINT_BEGIN();
     ASSERT(exec->codeBlock()->usesArguments());
-    Arguments* arguments = jsCast<Arguments*>(exec->uncheckedR(unmodifiedArgumentsRegister(VirtualRegister(pc[1].u.operand)).offset()).jsValue());
+    Arguments* arguments = jsCast<Arguments*>(exec->uncheckedR(VirtualRegister(pc[1].u.operand).offset()).jsValue());
     if (JSValue activationValue = LLINT_OP_C(2).jsValue())
         arguments->didTearOffActivation(exec, jsCast<JSLexicalEnvironment*>(activationValue));

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm

@@ -1956 +1956 @@
     traceExecution()
     loadi 4[PC], t0
-    addi 1, t0   # Get the unmodifiedArgumentsRegister
     bieq TagOffset[cfr, t0, 8], EmptyValueTag, .opTearOffArgumentsNotCreated
     callSlowPath(_llint_slow_path_tear_off_arguments)

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm

@@ -1814 +1814 @@
     traceExecution()
     loadisFromInstruction(1, t0)
-    addq 1, t0   # Get the unmodifiedArgumentsRegister
     btqz [cfr, t0, 8], .opTearOffArgumentsNotCreated
     callSlowPath(_llint_slow_path_tear_off_arguments)