Changeset 174682 in webkit for trunk/Source/JavaScriptCore/jit

Timestamp:

Oct 14, 2014, 9:25:25 AM (11 years ago)

Author:

[email protected]

Message:

[Win32] Thunk is not implemented.
​https://bugs.webkit.org/show_bug.cgi?id=137691

Patch by ​[email protected] <​[email protected]> on 2014-10-14
Reviewed by Mark Lam.

Thunks for functions with double operands (floor, etc.) are not implemented on Win32.

• jit/ThunkGenerators.cpp:

File:

• trunk/Source/JavaScriptCore/jit/ThunkGenerators.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/jit/ThunkGenerators.cpp

@@ -806 +806 @@
     extern "C" { \
         MathThunkCallingConvention function##Thunk(MathThunkCallingConvention); \
+    } \
+    static MathThunk UnaryDoubleOpWrapper(function) = &function##Thunk;
+
+#elif CPU(X86) && COMPILER(MSVC) && OS(WINDOWS)
+
+// MSVC does not accept floor, etc, to be called directly from inline assembly, so we need to wrap these functions.
+static double (_cdecl *floorFunction)(double) = floor;
+static double (_cdecl *ceilFunction)(double) = ceil;
+static double (_cdecl *expFunction)(double) = exp;
+static double (_cdecl *logFunction)(double) = log;
+static double (_cdecl *jsRoundFunction)(double) = jsRound;
+
+#define defineUnaryDoubleOpWrapper(function) \
+    extern "C" __declspec(naked) MathThunkCallingConvention function##Thunk(MathThunkCallingConvention) \
+    { \
+        __asm \
+        { \
+        __asm sub esp, 20 \
+        __asm movsd mmword ptr [esp], xmm0  \
+        __asm call function##Function \
+        __asm fstp qword ptr [esp] \
+        __asm movsd xmm0, mmword ptr [esp] \
+        __asm add esp, 20 \
+        __asm ret \
+        } \
     } \
     static MathThunk UnaryDoubleOpWrapper(function) = &function##Thunk;