Changeset 176508 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

Nov 22, 2014, 8:37:15 PM (10 years ago)

Author:

[email protected]

Message:

Clean up OwnPtr and PassOwnPtr in some of JS classes
​https://bugs.webkit.org/show_bug.cgi?id=138724

Reviewed by Filip Pizlo.

As a step to use std::unique_ptr<> and std::make_unique<>, this patch replaces
OwnPtr with std::unique_ptr<>. Besides create() factory function is removed as well.

• builtins/BuiltinExecutables.h:

(JSC::BuiltinExecutables::create): Deleted.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::createRareDataIfNecessary):

• bytecode/StructureStubInfo.h:
• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::hasRareData):
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):

• runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

• runtime/CodeCache.h:

(JSC::CodeCache::create): Deleted.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::clearRareData):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::createRareDataIfNeeded):

• runtime/RegExpConstructor.h:
• runtime/SmallStrings.cpp:

(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::singleCharacterStringRep):

• runtime/SmallStrings.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

File:

• trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/builtins/BuiltinExecutables.h

@@ -41 +41 @@
     WTF_MAKE_FAST_ALLOCATED;
 public:
-    static PassOwnPtr<BuiltinExecutables> create(VM& vm)
-    {
-        return adoptPtr(new BuiltinExecutables(vm));
-    }
-    
+    explicit BuiltinExecutables(VM&);
+
 #define EXPOSE_BUILTIN_EXECUTABLES(name, functionName, length) \
 UnlinkedFunctionExecutable* name##Executable(); \
@@ -54 +51 @@
     
 private:
-    BuiltinExecutables(VM&);
     VM& m_vm;
     UnlinkedFunctionExecutable* createBuiltinExecutable(const SourceCode&, const Identifier&);