Changeset 176553 in webkit for trunk/Source/JavaScriptCore/heap

Timestamp:

Nov 27, 2014, 4:51:32 PM (11 years ago)

Author:

[email protected]

Message:

Use std::unique_ptr instead of OwnPtr in JSC classes
​https://bugs.webkit.org/show_bug.cgi?id=139009

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

• bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):

• bytecode/DFGExitProfile.h:
• bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::add):

• bytecode/LazyOperandValueProfile.h:
• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):

• heap/MarkedBlock.h:

(JSC::MarkedBlock::clearNewlyAllocated):

• inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

• runtime/RegExp.cpp:

(JSC::RegExp::invalidateCode):

• runtime/RegExp.h:
• yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):

• yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):

• yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

Location:

trunk/Source/JavaScriptCore/heap

Files:

• MarkedBlock.cpp (modified) (2 diffs)
• MarkedBlock.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/heap/MarkedBlock.cpp

@@ -103 +103 @@
     // otherwise we would lose information on what's currently alive.
     if (sweepMode == SweepToFreeList && m_newlyAllocated)
-        m_newlyAllocated.clear();
+        m_newlyAllocated = nullptr;
 
     m_state = ((sweepMode == SweepToFreeList) ? FreeListed : Marked);
@@ -191 +191 @@
     
     ASSERT(!m_newlyAllocated);
-    m_newlyAllocated = adoptPtr(new WTF::Bitmap<atomsPerBlock>());
+    m_newlyAllocated = std::make_unique<WTF::Bitmap<atomsPerBlock>>();
 
     SetNewlyAllocatedFunctor functor(this);

trunk/Source/JavaScriptCore/heap/MarkedBlock.h

@@ -210 +210 @@
         WTF::Bitmap<atomsPerBlock, WTF::BitmapNotAtomic, uint8_t> m_rememberedSet;
 #endif
-        OwnPtr<WTF::Bitmap<atomsPerBlock>> m_newlyAllocated;
+        std::unique_ptr<WTF::Bitmap<atomsPerBlock>> m_newlyAllocated;
 
         DestructorType m_destructorType;
@@ -401 +401 @@
     {
         if (m_newlyAllocated) {
-            m_newlyAllocated.clear();
+            m_newlyAllocated = nullptr;
             return true;
         }