Changeset 177597 in webkit for trunk/Source/JavaScriptCore/ftl

Timestamp:

Dec 19, 2014, 2:14:20 PM (10 years ago)

Author:

[email protected]

Message:

Plug leak below LLVMCopyStringRepOfTargetData().
<​https://webkit.org/b/139832>

Reviewed by Michael Saboff.

LLVMCopyStringRepOfTargetData() returns a strdup()'ed string, so make sure
to free() it after we're done using it.

• ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

File:

• trunk/Source/JavaScriptCore/ftl/FTLCompile.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ftl/FTLCompile.cpp

@@ -645 +645 @@
         LLVMTargetMachineRef targetMachine = llvm->GetExecutionEngineTargetMachine(engine);
         LLVMTargetDataRef targetData = llvm->GetExecutionEngineTargetData(engine);
-        llvm->SetDataLayout(state.module, llvm->CopyStringRepOfTargetData(targetData));
+        char* stringRepOfTargetData = llvm->CopyStringRepOfTargetData(targetData);
+        llvm->SetDataLayout(state.module, stringRepOfTargetData);
+        free(stringRepOfTargetData);
 
         LLVMPassManagerRef functionPasses = 0;