Changeset 179791 in webkit for trunk/Source/JavaScriptCore/profiler

Timestamp:

Feb 7, 2015, 6:28:48 PM (10 years ago)

Author:

Chris Dumez

Message:

Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
​https://bugs.webkit.org/show_bug.cgi?id=141321

Reviewed by Darin Adler.

Source/JavaScriptCore:

Use new Vector::removeFirstMatching() / removeAllMatching() methods.

Source/WebCore:

Use new Vector::removeFirstMatching() / removeAllMatching() methods.

Source/WebKit/win:

Use new Vector::removeFirstMatching() / removeAllMatching() methods.

Source/WebKit2:

Use new Vector::removeFirstMatching() / removeAllMatching() methods.

Source/WTF:

Add Vector::removeFirstMatching() / removeAllMatching() methods taking
lambda functions to match the element(s) to remove. This simplifies the
code a bit. Vector::removeAllMatching() is also more efficient than the
manual removal alternative.

• wtf/Vector.h:

Tools:

Use new Vector::removeFirstMatching() / removeAllMatching() methods.

File:

• trunk/Source/JavaScriptCore/profiler/ProfileNode.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/profiler/ProfileNode.cpp

@@ -76 +76 @@
         return;
 
-    for (size_t i = 0; i < m_children.size(); ++i) {
-        if (*node == m_children[i].get()) {
-            m_children.remove(i);
-            break;
-        }
-    }
+    m_children.removeFirstMatching([node] (const RefPtr<ProfileNode>& current) {
+        return *node == current.get();
+    });
 
 #ifndef NDEBUG