Changeset 180622 in webkit for trunk/Source/JavaScriptCore/llvm

Timestamp:

Feb 25, 2015, 2:18:41 AM (10 years ago)

Author:

[email protected]

Message:

Need to pass RTLD_DEEPBIND to dlopen() to ensure that our LLVMOverrides take effect on Linux
​https://bugs.webkit.org/show_bug.cgi?id=142006

Reviewed by Csaba Osztrogonác.

This fixes hard-to-reproduce concurrency-related crashes when running stress tests with FTL and
concurrent JIT enabled.

• llvm/InitializeLLVMPOSIX.cpp:

(JSC::initializeLLVMPOSIX):

File:

• trunk/Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp

@@ -49 +49 @@
         || Options::showDisassembly();
     
-    void* library = dlopen(libraryName, RTLD_NOW);
+    int flags = RTLD_NOW;
+    
+#if OS(LINUX)
+    // We need this to cause our overrides (like __cxa_atexit) to take precedent over the __cxa_atexit that is already
+    // globally exported. Those overrides are necessary to prevent crashes (our __cxa_atexit turns off LLVM's exit-time
+    // destruction, which causes exit-time crashes if the concurrent JIT is still running) and to make LLVM assertion
+    // failures funnel through WebKit's mechanisms. This flag induces behavior that is the default on Darwin. Other OSes
+    // may need their own flags in place of this.
+    flags |= RTLD_DEEPBIND;
+#endif
+    
+    void* library = dlopen(libraryName, flags);
     if (!library) {
         if (verbose)