Changeset 18182 in webkit for trunk/JavaScriptCore/tests

Timestamp:

Dec 12, 2006, 12:09:58 PM (18 years ago)

Author:

ap

Message:

Reviewed by Geoff. Based on a patch by Maks Orlovich.

​http://bugs.webkit.org/show_bug.cgi?id=6257
Throw errors on invalid expressions (KJS merge)

JavaScriptCore:

• kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
• kjs/regexp.h: (KJS::RegExp::flags): (KJS::RegExp::isValid): (KJS::RegExp::errorMessage): (KJS::RegExp::subPatterns): Remember and report RegExp construction failures. Renamed data members not to start with underscores.

• kjs/regexp_object.cpp: (RegExpObjectImp::construct): Raise an exception if RegExp construction fails. (RegExpObjectImp::callAsFunction): Removed an obsolete comment.

• tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to a value supported by PCRE.

LayoutTests:

• fast/js/kde/RegExp-expected.txt: One more test passes.

File:

• trunk/JavaScriptCore/tests/mozilla/ecma_3/RegExp/regress-119909.js (modified) (1 diff)

trunk/JavaScriptCore/tests/mozilla/ecma_3/RegExp/regress-119909.js

@@ -58 +58 @@
   printStatus(summary);
 
-  testThis(500, NO_BACKREFS, 'hello', 'goodbye');
-  testThis(500, DO_BACKREFS, 'hello', 'goodbye');
+  // Changed the parameter from 500 to 200 for WebKit, because PCRE reports an error for more parentheses.
+  testThis(200, NO_BACKREFS, 'hello', 'goodbye');
+  testThis(200, DO_BACKREFS, 'hello', 'goodbye');
 
   exitFunc('test');