Changeset 18256 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Dec 16, 2006, 4:31:30 AM (18 years ago)

Author:

ap

Message:

Reviewed by Rob.

A deleted object was accessed to prepare RegExp construction error messages.

• kjs/regexp_object.cpp: (RegExpObjectImp::construct): Wrap the RegExp into an OwnPtr.

File:

• trunk/JavaScriptCore/kjs/regexp_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/regexp_object.cpp

@@ -398 +398 @@
   if (multiline)
       reflags |= RegExp::Multiline;
-  RegExp* re = new RegExp(p, reflags);
-  if (!re->isValid()) {
-    delete re;
-    return throwError(exec, SyntaxError, UString("Invalid regular expression: ").append(re->errorMessage()));
-  }
-  dat->setRegExp(re);
+
+  OwnPtr<RegExp> re(new RegExp(p, reflags));
+  if (!re->isValid())
+      return throwError(exec, SyntaxError, UString("Invalid regular expression: ").append(re->errorMessage()));
+
+  dat->setRegExp(re.release());
 
   return dat;