Changeset 184848 in webkit for trunk/Source/JavaScriptCore/builtins

Timestamp:

May 24, 2015, 8:51:17 PM (10 years ago)

Author:

[email protected]

Message:

Array#findIndex/find should not skip holes
​https://bugs.webkit.org/show_bug.cgi?id=145361
Source/JavaScriptCore:

per ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.findindex
and ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.find

Patch by Jordan Harband <​[email protected]> on 2015-05-24
Reviewed by Yusuke Suzuki.

• builtins/Array.prototype.js:

(find): Deleted.
(findIndex): Deleted.

LayoutTests:

Patch by Jordan Harband <​[email protected]> on 2015-05-24
Reviewed by Yusuke Suzuki.

• js/array-find-expected.txt:
• js/array-findIndex-expected.txt:
• js/script-tests/array-find.js:
• js/script-tests/array-findIndex.js:

File:

• trunk/Source/JavaScriptCore/builtins/Array.prototype.js (modified) (2 diffs)

trunk/Source/JavaScriptCore/builtins/Array.prototype.js

@@ -209 +209 @@
     var thisArg = arguments.length > 1 ? arguments[1] : undefined;
     for (var i = 0; i < length; i++) {
-        if (!(i in array))
-            continue;
         var kValue = array[i];
         if (callback.@call(thisArg, kValue, i, array))
@@ -234 +232 @@
     var thisArg = arguments.length > 1 ? arguments[1] : undefined;
     for (var i = 0; i < length; i++) {
-        if (!(i in array))
-            continue;
         if (callback.@call(thisArg, array[i], i, array))
             return i;